From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Miller <davem@davemloft.net>
Cc: "annie.li@oracle.com" <annie.li@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx_queue
Date: Fri, 29 Jun 2012 08:23:09 +0100 [thread overview]
Message-ID: <1340954589.5953.12.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <20120628.165550.1816352825092253548.davem@davemloft.net>
On Fri, 2012-06-29 at 00:55 +0100, David Miller wrote:
> From: annie.li@oracle.com
> Date: Wed, 27 Jun 2012 18:46:58 +0800
>
> > From: Annie Li <Annie.li@oracle.com>
> >
> > After SKB is queued into tx_queue, it will be freed if request_gop is NULL.
> > However, no dequeue action is called in this situation, it is likely that
> > tx_queue constains freed SKB. This patch should fix this issue, and it is
> > based on 3.5.0-rc4+.
> >
> > This issue is found through code inspection, no bug is seen with it currently.
> > I run netperf test for several hours, and no network regression was found.
> >
> > Signed-off-by: Annie Li <annie.li@oracle.com>
>
> I lack the expertiece necessary to properly review this, so I really
> need a Xen expert to look this over.
Sorry, I put it to one side waiting for the repost to netdev and then
forgot about it...
Yes, this change looks good to me:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2012-06-29 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 10:46 [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx_queue annie.li
2012-06-28 23:55 ` David Miller
2012-06-29 7:23 ` Ian Campbell [this message]
2012-06-29 7:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340954589.5953.12.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=annie.li@oracle.com \
--cc=davem@davemloft.net \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox