From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yuval Mintz" Subject: [PATCH net-next 00/11] default maximal number of RSS queues in mq drivers Date: Sun, 1 Jul 2012 16:18:49 +0300 Message-ID: <1341148740-7375-1-git-send-email-yuvalmin@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: eilong@broadcom.com, "Yuval Mintz" , "Divy Le Ray" , "Or Gerlitz" , "Jon Mason" , "Anirban Chakraborty" , "Jitendra Kalsaria" , "Ron Mercer" , "Jeff Kirsher" , "Jon Mason" , "Andrew Gallatin" , "Sathya Perla" , "Subbu Seetharaman" , "Ajit Khaparde" , "Matt Carlson" , "Michael Chan" , "Eric Dumazet" , "Ben Hutchings" To: davem@davemloft.net, netdev@vger.kernel.org Return-path: Received: from mms3.broadcom.com ([216.31.210.19]:3380 "EHLO mms3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755390Ab2GANUb (ORCPT ); Sun, 1 Jul 2012 09:20:31 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Different vendors support different number of RSS queues by default. Today, there exists an ethtool API through which users can change the number of channels their driver supports; This enables us to pursue the goal of using a default number of RSS queues in various multi-queue drivers. This patch intendeds to achieve the above default, by upper-limiting the number of interrupts multi-queue drivers request (by default, not via the new API) with correlation to the number of cpus on the machine. After examining multi-queue drivers that call alloc_etherdev_mq[s], it became evident that most drivers allocate their devices using hard-coded values. Changing those defaults directly will most likely cause a regression. However, (most) multi-queue driver look at the number of online cpus when requesting for interrupts. We assume that the number of interrupts the driver manages to request is propagated across the driver, and the number of RSS queues it configures is based upon it. This patch modifies said logic - if the number of cpus is large enough, use a smaller default value instead. This serves 2 main purposes: 1. A step forward unity in the number of RSS queues of various drivers. 2. It prevents wasteful requests for memory on machines with many cpus. Notice no testing was made on this patch (other than on the bnx2x driver) except for compilation test. This patch is based on RFC: http://marc.info/?l=linux-netdev&m=134062509310404&w=2 Drivers identified as multi-queue, handled in this patch: * mellanox mlx4 * neterion vxge * qlogic qlge * chelsio cxgb3, cxgb4 * myricom myri10ge * emulex benet * broadcom tg3, bnx2, bnx2x The guys at Intel requested to change their drivers' behaviour on their own, in order to support ethtool's [g|s]et_channels. Thus, igb, igbx2, and igbxevf were not handled in this patch. Driver identified as multi-queue, no reference to number of online cpus found, and thus unhandled in this patch: * neterion s2io * marvell mv643xx * freescale gianfar * ibm ehea * ti cpmac * sun niu * sfc efx * chelsio cxgb4vf Cheers, Yuval Mintz Cc: Divy Le Ray Cc: Or Gerlitz Cc: Jon Mason Cc: Anirban Chakraborty Cc: Jitendra Kalsaria Cc: Ron Mercer Cc: Jeff Kirsher Cc: Jon Mason Cc: Andrew Gallatin Cc: Sathya Perla Cc: Subbu Seetharaman Cc: Ajit Khaparde Cc: Matt Carlson Cc: Michael Chan Cc: Eric Dumazet Cc: Ben Hutchings