From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH 0/5] rtcache remove respin Date: Mon, 02 Jul 2012 12:44:01 +0200 Message-ID: <1341225841.5269.69.camel@edumazet-glaptop> References: <20120701.050243.908285695895815999.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:45423 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932931Ab2GBKoE (ORCPT ); Mon, 2 Jul 2012 06:44:04 -0400 Received: by eaak11 with SMTP id k11so2021660eaa.19 for ; Mon, 02 Jul 2012 03:44:03 -0700 (PDT) In-Reply-To: <20120701.050243.908285695895815999.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 2012-07-01 at 05:02 -0700, David Miller wrote: > It's been a while and there were of course a lot of merge hassles with > the most recent set I posted, so I respun these patches tonight > because I wanted to see the effects of the recent rpfilter hacks on an > rtcache-less system. > > On a SPARC T3-1: > > 1) Output route lookup: ~2800 cycles > 2) Input route lookups: ~3000 cycles (rpfilter=0) > ~4300 cycles (rpfilter=1) > > Another nice part is how small struct rtable is after this patch set: > > struct rtable { > struct dst_entry dst; > int rt_genid; > unsigned int rt_flags; > __u16 rt_type; > __be32 rt_dst; > int rt_route_iif; > int rt_iif; > int rt_oif; > __be32 rt_gateway; > u32 rt_peer_genid; > unsigned long _peer; > struct fib_info *fi; > }; > > which is about 208 bytes on sparc64. > > Signed-off-by: David S. Miller Can be <= 192 actually rcu_head not needed anymore in dst_entry If we still want __refcnt being on cache line boundary, we might find a better way to accomplish this.