From: Joe Perches <joe@perches.com>
To: Greg Ungerer <gerg@snapgear.com>
Cc: netdev@vger.kernel.org, linux-m68k@vger.kernel.org,
Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH 2/2] net: add support for NS8390 based eth controllers on some ColdFire CPU boards
Date: Tue, 03 Jul 2012 23:39:59 -0700 [thread overview]
Message-ID: <1341383999.3627.20.camel@joe2Laptop> (raw)
In-Reply-To: <4FF3E031.5040703@snapgear.com>
On Wed, 2012-07-04 at 16:18 +1000, Greg Ungerer wrote:
> Hi Joe,
Hi Greg.
> On 04/07/12 15:18, Joe Perches wrote:
> > On Wed, 2012-07-04 at 14:56 +1000, gerg@snapgear.com wrote:
> >> From: Greg Ungerer <gerg@uclinux.org>
> >>
> >> A number of older ColdFire CPU based boards use NS8390 based network
> >> controllers. Most use the Davicom 9008F or the UMC 9008F. This driver
> >> provides the support code to get these devices working on these platforms.
[]
> >> diff --git a/drivers/net/ethernet/8390/mcf8390.c b/drivers/net/ethernet/8390/mcf8390.c
[]
> >> +static int mcf8390_init(struct net_device *dev)
> >> +{
> >> + static u32 offsets[] = {
> >> + 0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
> >> + 0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
> >> + };
> >
> > const? u8?
>
> That is assigned to the "reg_offset" field of "struct ei_device"
> (defined in the existing 8390.h) and that is:
>
> u32 *reg_offset; /* Register mapping table */
>
> So I can't change this.
Sure you can, you can assign a u8 to a u32 just fine.
The value fits in a u8. Might as well make it take
less data space. static const makes it read-only and
makes the compiler assign it just once instead of at
function invocation.
cheers, Joe
next prev parent reply other threads:[~2012-07-04 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 4:56 [PATCH 0/2] net: support for NS8390 based ethernet on ColdFire CPU boards gerg
2012-07-04 4:56 ` [PATCH 1/2] m68knommu: move the badly named mcfne.h to a better mcf8390.h gerg
2012-07-04 4:56 ` [PATCH 2/2] net: add support for NS8390 based eth controllers on some ColdFire CPU boards gerg
2012-07-04 5:18 ` Joe Perches
2012-07-04 6:18 ` Greg Ungerer
2012-07-04 6:39 ` Joe Perches [this message]
2012-07-04 7:52 ` Geert Uytterhoeven
2012-07-04 8:06 ` Greg Ungerer
2012-07-04 14:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341383999.3627.20.camel@joe2Laptop \
--to=joe@perches.com \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox