From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: ja@ssi.bg, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Create and use fib_compute_spec_dst() helper.
Date: Thu, 05 Jul 2012 10:10:21 +0200 [thread overview]
Message-ID: <1341475821.2583.3362.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120705.005940.1078811938047681715.davem@davemloft.net>
On Thu, 2012-07-05 at 00:59 -0700, David Miller wrote:
> Yes, this is a great idea. Actually in some obscure cases your
> change can cause us to compute it more than once I think.
>
> I'd suggest we do something like create a helper function above this
> code in ip_options.c that checks whether spec_dst is INADDR_ANY or
> not, to guard computing it multiple times.
>
> Could you put together a quick patch like that?
Sure I'll do that.
prev parent reply other threads:[~2012-07-05 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 10:59 [PATCH] ipv4: Create and use fib_compute_spec_dst() helper David Miller
2012-06-28 23:16 ` Julian Anastasov
2012-06-28 23:27 ` David Miller
2012-06-29 1:45 ` David Miller
2012-06-30 9:25 ` Julian Anastasov
2012-07-04 15:21 ` Eric Dumazet
2012-07-04 23:13 ` David Miller
2012-07-05 7:52 ` Eric Dumazet
2012-07-05 7:59 ` David Miller
2012-07-05 8:10 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341475821.2583.3362.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox