From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christian Riesch <christian.riesch@omicron.at>
Cc: netdev@vger.kernel.org, Oliver Neukum <oneukum@suse.de>,
Eric Dumazet <edumazet@google.com>,
Allan Chou <allan@asix.com.tw>, Mark Lord <kernel@teksavvy.com>,
Grant Grundler <grundler@chromium.org>,
Ming Lei <tom.leiming@gmail.com>,
Michael Riesch <michael@riesch.at>
Subject: Re: [PATCH 1/4] asix: Fix checkpatch warnings
Date: Fri, 06 Jul 2012 13:58:39 +0200 [thread overview]
Message-ID: <1341575919.3265.499.camel@edumazet-glaptop> (raw)
In-Reply-To: <1341574388-7464-2-git-send-email-christian.riesch@omicron.at>
On Fri, 2012-07-06 at 13:33 +0200, Christian Riesch wrote:
> Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
> ---
> - netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
> + netdev_err(dev->net, "Error reading PHYID register: %02x\n",
> + ret);
Thats ridiculous
Not all checkpatch warnings are meaningful.
I mean, they probably are for new code, but for existing one this is a
waste of time.
next prev parent reply other threads:[~2012-07-06 11:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 11:33 [PATCH 0/4] Add a driver for the ASIX AX88172A Christian Riesch
2012-07-06 11:33 ` [PATCH 1/4] asix: Fix checkpatch warnings Christian Riesch
2012-07-06 11:58 ` Eric Dumazet [this message]
2012-07-06 12:02 ` David Miller
2012-07-06 21:43 ` Grant Grundler
2012-07-07 8:36 ` Eric Dumazet
2012-07-09 9:48 ` Christian Riesch
2012-07-06 15:25 ` Joe Perches
2012-07-06 11:33 ` [PATCH 2/4] asix: Rename asix.c to asix_devices.c Christian Riesch
2012-07-06 11:33 ` [PATCH 3/4] asix: Factor out common code Christian Riesch
2012-07-06 11:33 ` [PATCH 4/4] asix: Add a new driver for the AX88172A Christian Riesch
2012-07-06 17:37 ` Ben Hutchings
2012-07-08 15:39 ` Michael Riesch
2012-07-08 15:50 ` Ben Hutchings
2012-07-09 10:30 ` Christian Riesch
2012-07-11 8:27 ` Christian Riesch
2012-07-11 15:10 ` Christian Riesch
2012-07-11 19:23 ` Michael Riesch
2012-07-06 21:20 ` Grant Grundler
2012-07-09 10:22 ` Christian Riesch
2012-07-12 7:22 ` Christian Riesch
2012-07-12 23:10 ` Grant Grundler
2012-07-06 11:51 ` [PATCH 0/4] Add a driver for the ASIX AX88172A Christian Riesch
2012-07-09 2:38 ` ASIX Allan Email [office]
2012-07-09 10:18 ` Christian Riesch
2012-07-09 17:45 ` Grant Grundler
2012-07-09 22:27 ` Mark Lord
2012-07-10 2:20 ` ASIX Allan Email [office]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341575919.3265.499.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=allan@asix.com.tw \
--cc=christian.riesch@omicron.at \
--cc=edumazet@google.com \
--cc=grundler@chromium.org \
--cc=kernel@teksavvy.com \
--cc=michael@riesch.at \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox