* [PATCH] r6040: remove duplicate call to the pci_set_drvdata
@ 2012-07-07 6:07 Devendra Naga
2012-07-07 23:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Naga @ 2012-07-07 6:07 UTC (permalink / raw)
To: Florian Fainelli, netdev; +Cc: Devendra Naga
pci_set_drvdata is called twice at the remove path of driver,
call it once.
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
---
drivers/net/ethernet/rdc/r6040.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index d1827e8..9acc026 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1256,7 +1256,6 @@ static void __devexit r6040_remove_one(struct pci_dev *pdev)
kfree(lp->mii_bus->irq);
mdiobus_free(lp->mii_bus);
netif_napi_del(&lp->napi);
- pci_set_drvdata(pdev, NULL);
pci_iounmap(pdev, lp->base);
pci_release_regions(pdev);
free_netdev(dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r6040: remove duplicate call to the pci_set_drvdata
2012-07-07 6:07 [PATCH] r6040: remove duplicate call to the pci_set_drvdata Devendra Naga
@ 2012-07-07 23:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-07 23:16 UTC (permalink / raw)
To: devendra.aaru; +Cc: florian, netdev
From: Devendra Naga <devendra.aaru@gmail.com>
Date: Sat, 7 Jul 2012 11:37:35 +0530
> pci_set_drvdata is called twice at the remove path of driver,
> call it once.
>
> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-07 23:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-07 6:07 [PATCH] r6040: remove duplicate call to the pci_set_drvdata Devendra Naga
2012-07-07 23:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).