From: Eric Dumazet <eric.dumazet@gmail.com>
To: Merav Sicron <meravs@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, eilong@broadcom.com, dmitry@broadcom.com
Subject: Re: [net-next patch] bnx2x: Add run-time CNIC support
Date: Sun, 08 Jul 2012 13:14:03 +0200 [thread overview]
Message-ID: <1341746043.3265.1653.camel@edumazet-glaptop> (raw)
In-Reply-To: <1341745239.27284.13.camel@lb-tlvb-meravs.il.broadcom.com>
On Sun, 2012-07-08 at 14:00 +0300, Merav Sicron wrote:
> static int set_is_cnic_enabled(bool is_vf)
> {
> if (is_vf)
> return 0;
> #if defined(CONFIG_CNIC) || defined(CONFIG_CNIC_MODULE)
> return 1;
> #else
> return 0;
> #endif
> }
Small note : this should use booleans and can use
if (is_vf)
return false;
return IS_ENABLED(CONFIG_CNIC);
next prev parent reply other threads:[~2012-07-08 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-08 9:48 [net-next patch] bnx2x: Add run-time CNIC support Merav Sicron
2012-07-08 10:31 ` David Miller
2012-07-08 11:00 ` Merav Sicron
2012-07-08 11:14 ` Eric Dumazet [this message]
2012-07-08 12:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341746043.3265.1653.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=meravs@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox