From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lizefan@huawei.com, tj@kernel.org,
Gao feng <gaofeng@cn.fujitsu.com>
Subject: Re: [PATCH] net: cgroup: fix out of bounds accesses
Date: Mon, 09 Jul 2012 14:40:25 +0200 [thread overview]
Message-ID: <1341837625.3265.2748.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120709121350.GC9186@hmsreliant.think-freely.org>
On Mon, 2012-07-09 at 08:13 -0400, Neil Horman wrote:
> On Mon, Jul 09, 2012 at 01:50:52PM +0200, Eric Dumazet wrote:
> > On Mon, 2012-07-09 at 07:01 -0400, Neil Horman wrote:
> >
> > > Thank you for doing this Eric, Gao. Just to be sure (I asked in the previous
> > > thread), would it be better to avoid the length check in skb_update_prio, and
> > > instead update the netdev tables to be long enough in cgrp_create and in
> > > netprio_device_event on device registration?
> >
> > Yes probably, and it is even needed because extend_netdev_table() can
> > acutally fail to expand the table if kzalloc() returned NULL.
> >
> > Current code just ignores this allocation failure so we also can crash
> > in write_priomap()
> >
> ACK, can you follow up with a patch please?
Gao was working on this allocation problem (he privately sent me a v1 of
his patch), so I think we can wait Gao submit a v2 to combine all the
work/ideas in a single patch.
(ie make sure we dont need additional bound checkings in fast path)
next prev parent reply other threads:[~2012-07-09 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-09 7:45 [PATCH] net: cgroup: fix out of bounds accesses Eric Dumazet
2012-07-09 8:15 ` Gao feng
2012-07-09 21:51 ` David Miller
2012-07-10 2:33 ` Gao feng
2012-07-10 2:37 ` David Miller
2012-07-09 11:01 ` Neil Horman
2012-07-09 11:50 ` Eric Dumazet
2012-07-09 12:13 ` Neil Horman
2012-07-09 12:40 ` Eric Dumazet [this message]
2012-07-09 12:56 ` Neil Horman
2012-07-10 2:31 ` [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup Gao feng
2012-07-10 4:14 ` Eric Dumazet
2012-07-10 8:53 ` Gao feng
2012-07-10 9:15 ` Eric Dumazet
2012-07-10 9:36 ` Gao feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341837625.3265.2748.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=gaofeng@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox