From: Daniel Wagner <wagi@monom.org>
To: cgroups@vger.kernel.org
Cc: netdev@vger.kernel.org, Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH v2 0/5] cgroup cls & netprio 'cleanups'
Date: Wed, 11 Jul 2012 11:35:36 +0200 [thread overview]
Message-ID: <1341999341-1808-1-git-send-email-wagi@monom.org> (raw)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Hi,
While looking a bit at the cls and netprio controller I found a
few things which I think are 'not optimal'.
The first patch makes sock_update_netprioidx() a bit smatter, so that
only on changed value the sk->sk_cgroup_prioidx is written and not
all the time.
The next two patches are changing the built. In case someone
builds a kernel with cgroup support but disabled cls or netprio
controller, there was still code added.
And the last two patches change the cls and netprio source files in
that way, that the use IS_BUILTIN and IS_MODULE as it used in the
header files.
The patches are against net-next.
cheers,
daniel
Daniel Wagner (5):
cgroup: Only update sk_cgrp_prioidx on change
cgroup: Do not add sock_update_classid() when CONFIG_NET_CLS_CGROUP=0
cgroup: Do not add sock_update_netprioidx() when
CONFIG_NETPRIO_CGROUP=0
cgroup: Make builtin vs. module build ifdefs consistent
cgroup: Make builtin vs. module build ifdefs consistent
include/net/cls_cgroup.h | 33 +++++++++++++++++++++++----------
include/net/netprio_cgroup.h | 31 ++++++++++++++-----------------
include/net/sock.h | 8 --------
net/core/netprio_cgroup.c | 6 +++---
net/core/sock.c | 14 +++++++++++---
net/sched/cls_cgroup.c | 6 +++---
6 files changed, 54 insertions(+), 44 deletions(-)
--
1.7.11.1.165.g299666c
next reply other threads:[~2012-07-11 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 9:35 Daniel Wagner [this message]
2012-07-11 9:35 ` [PATCH v2 1/5] cgroup: Only update sk_cgrp_prioidx on change Daniel Wagner
2012-07-11 9:35 ` [PATCH v2 3/5] cgroup: Do not add sock_update_netprioidx() when CONFIG_NETPRIO_CGROUP=0 Daniel Wagner
2012-07-11 9:35 ` [PATCH v2 4/5] cgroup: Make builtin vs. module build ifdefs consistent Daniel Wagner
[not found] ` <1341999341-1808-1-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org>
2012-07-11 9:35 ` [PATCH v2 2/5] cgroup: Do not add sock_update_classid() when CONFIG_NET_CLS_CGROUP=0 Daniel Wagner
2012-07-11 9:35 ` [PATCH v2 5/5] cgroup: Make builtin vs. module build ifdefs consistent Daniel Wagner
2012-07-13 13:53 ` [PATCH v2 0/5] cgroup cls & netprio 'cleanups' Daniel Wagner
2012-07-13 15:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341999341-1808-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).