From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jeffrey.t.kirsher@intel.com, alexander.duyck@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH 2/2] net: Update alloc frag to reduce get/put page usage and recycle pages
Date: Thu, 12 Jul 2012 02:29:27 +0200 [thread overview]
Message-ID: <1342052967.3265.8210.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120712001810.26542.61967.stgit@gitlad.jf.intel.com>
On Wed, 2012-07-11 at 17:18 -0700, Alexander Duyck wrote:
> This patch does several things.
>
> First it reorders the netdev_alloc_frag code so that only one conditional
> check is needed in most cases instead of 2.
>
> Second it incorporates the atomic_set and atomic_sub_return logic from an
> earlier proposed patch by Eric Dumazet allowing for a reduction in the
> get_page/put_page overhead when dealing with frags.
>
> Finally it also incorporates the page reuse code so that if the page count
> is dropped to 0 we can just reinitialize the page and reuse it.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
Hmm, I was working on a version using order-3 pages if available.
(or more exactly 32768 bytes chunks)
I am not sure how your version can help with typical 1500 allocations
(2 skbs per page)
next prev parent reply other threads:[~2012-07-12 0:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 0:18 [PATCH 1/2] tcp: Fix out of bounds access to tcpm_vals Alexander Duyck
2012-07-12 0:18 ` [PATCH 2/2] net: Update alloc frag to reduce get/put page usage and recycle pages Alexander Duyck
2012-07-12 0:29 ` Eric Dumazet [this message]
2012-07-12 1:11 ` David Miller
2012-07-12 2:02 ` Alexander Duyck
2012-07-12 5:06 ` Eric Dumazet
2012-07-12 15:33 ` Alexander Duyck
2012-07-12 0:32 ` [PATCH 1/2] tcp: Fix out of bounds access to tcpm_vals David Miller
2012-07-12 1:46 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342052967.3265.8210.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox