From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Jon Maloy <jon.maloy@ericsson.com>,
Erik Hugne <erik.hugne@ericsson.com>,
ying.xue@windriver.com,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH net-next 2/8] tipc: limit error messages relating to memory leak to one line
Date: Thu, 12 Jul 2012 12:39:55 -0400 [thread overview]
Message-ID: <1342111201-9426-3-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1342111201-9426-1-git-send-email-paul.gortmaker@windriver.com>
With the default name table size of 1024, it is possible that
the sanity check in tipc_nametbl_stop could spam out 1024
essentially identical error messages if memory was corrupted
or similar. Limit it to issuing no more than a single message.
The actual chain number (i.e. 0 --> 1023) wouldn't provide any
useful insight if/when such an instance happened, so don't
bother printing out that value.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
net/tipc/name_table.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
index 13fb9d5..cade0ac 100644
--- a/net/tipc/name_table.c
+++ b/net/tipc/name_table.c
@@ -940,8 +940,10 @@ void tipc_nametbl_stop(void)
/* Verify name table is empty, then release it */
write_lock_bh(&tipc_nametbl_lock);
for (i = 0; i < tipc_nametbl_size; i++) {
- if (!hlist_empty(&table.types[i]))
- err("tipc_nametbl_stop(): hash chain %u is non-null\n", i);
+ if (hlist_empty(&table.types[i]))
+ continue;
+ err("tipc_nametbl_stop(): orphaned hash chain detected\n");
+ break;
}
kfree(table.types);
table.types = NULL;
--
1.7.9.7
next prev parent reply other threads:[~2012-07-12 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 16:39 [PATCH net-next 0/8] tipc: kill off struct print_buf/log Paul Gortmaker
2012-07-12 16:39 ` [PATCH net-next 1/8] tipc: factor stats struct out of the larger link struct Paul Gortmaker
2012-07-12 16:39 ` Paul Gortmaker [this message]
2012-07-12 16:39 ` [PATCH net-next 3/8] tipc: use standard printk shortcut macros (pr_err etc.) Paul Gortmaker
2012-07-13 23:53 ` [PATCH net-next v2 " Paul Gortmaker
2012-07-12 16:39 ` [PATCH net-next 4/8] tipc: remove TIPC packet debugging functions and macros Paul Gortmaker
2012-07-12 16:39 ` [PATCH net-next 5/8] tipc: simplify link_print by divorcing it from using tipc_printf Paul Gortmaker
2012-07-12 16:39 ` [PATCH net-next 6/8] tipc: simplify print buffer handling in tipc_printf Paul Gortmaker
2012-07-12 16:40 ` [PATCH net-next 7/8] tipc: phase out most of the struct print_buf usage Paul Gortmaker
2012-07-12 16:40 ` [PATCH net-next 8/8] tipc: remove print_buf and deprecated log buffer code Paul Gortmaker
2012-07-12 17:51 ` [PATCH net-next] tipc: Use pr_fmt Joe Perches
2012-07-13 15:45 ` Paul Gortmaker
2012-07-13 19:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342111201-9426-3-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).