* [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed
@ 2012-07-13 17:16 Ioan Orghici
2012-07-14 18:01 ` Vlad Yasevich
2012-07-17 6:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ioan Orghici @ 2012-07-13 17:16 UTC (permalink / raw)
To: vyasevich, sri, davem, netdev; +Cc: Ioan Orghici
Fix the following sparse warning:
* symbol 'sctp_init_cause_fixed' was not declared. Should it be
static?
Signed-off-by: Ioan Orghici <ioanorghici@gmail.com>
---
net/sctp/sm_make_chunk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index b6de71e..479a70e 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -132,7 +132,7 @@ void sctp_init_cause(struct sctp_chunk *chunk, __be16 cause_code,
* abort chunk. Differs from sctp_init_cause in that it won't oops
* if there isn't enough space in the op error chunk
*/
-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
size_t paylen)
{
sctp_errhdr_t err;
--
1.7.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed
2012-07-13 17:16 [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed Ioan Orghici
@ 2012-07-14 18:01 ` Vlad Yasevich
2012-07-17 6:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Vlad Yasevich @ 2012-07-14 18:01 UTC (permalink / raw)
To: Ioan Orghici, sri, davem, netdev
Ioan Orghici <ioanorghici@gmail.com> wrote:
>Fix the following sparse warning:
> * symbol 'sctp_init_cause_fixed' was not declared. Should it be
> static?
>
>Signed-off-by: Ioan Orghici <ioanorghici@gmail.com>
Looks good.
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
>---
> net/sctp/sm_make_chunk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
>index b6de71e..479a70e 100644
>--- a/net/sctp/sm_make_chunk.c
>+++ b/net/sctp/sm_make_chunk.c
>@@ -132,7 +132,7 @@ void sctp_init_cause(struct sctp_chunk *chunk,
>__be16 cause_code,
> * abort chunk. Differs from sctp_init_cause in that it won't oops
> * if there isn't enough space in the op error chunk
> */
>-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
>+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16
>cause_code,
> size_t paylen)
> {
> sctp_errhdr_t err;
>--
>1.7.6.3
--
Sent from my Android phone with SkitMail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed
2012-07-13 17:16 [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed Ioan Orghici
2012-07-14 18:01 ` Vlad Yasevich
@ 2012-07-17 6:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-07-17 6:24 UTC (permalink / raw)
To: ioanorghici; +Cc: vyasevich, sri, netdev
From: Ioan Orghici <ioanorghici@gmail.com>
Date: Fri, 13 Jul 2012 20:16:37 +0300
> Fix the following sparse warning:
> * symbol 'sctp_init_cause_fixed' was not declared. Should it be
> static?
>
> Signed-off-by: Ioan Orghici <ioanorghici@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-17 6:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-13 17:16 [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed Ioan Orghici
2012-07-14 18:01 ` Vlad Yasevich
2012-07-17 6:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).