* [net] ixgbevf: Prevent RX/TX statistics getting reset to zero
@ 2012-07-17 1:24 Jeff Kirsher
2012-07-17 5:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2012-07-17 1:24 UTC (permalink / raw)
To: davem; +Cc: Narendra K, netdev, gospo, sassmann, Jeff Kirsher
From: Narendra K <narendra_k@dell.com>
The commit 4197aa7bb81877ebb06e4f2cc1b5fea2da23a7bd implements 64 bit
per ring statistics. But the driver resets the 'total_bytes' and
'total_packets' from RX and TX rings in the RX and TX interrupt
handlers to zero. This results in statistics being lost and user space
reporting RX and TX statistics as zero. This patch addresses the
issue by preventing the resetting of RX and TX ring statistics to
zero.
Signed-off-by: Narendra K <narendra_k@dell.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index f69ec42..8b304a4 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -969,8 +969,6 @@ static irqreturn_t ixgbevf_msix_clean_tx(int irq, void *data)
r_idx = find_first_bit(q_vector->txr_idx, adapter->num_tx_queues);
for (i = 0; i < q_vector->txr_count; i++) {
tx_ring = &(adapter->tx_ring[r_idx]);
- tx_ring->total_bytes = 0;
- tx_ring->total_packets = 0;
ixgbevf_clean_tx_irq(adapter, tx_ring);
r_idx = find_next_bit(q_vector->txr_idx, adapter->num_tx_queues,
r_idx + 1);
@@ -994,16 +992,6 @@ static irqreturn_t ixgbevf_msix_clean_rx(int irq, void *data)
struct ixgbe_hw *hw = &adapter->hw;
struct ixgbevf_ring *rx_ring;
int r_idx;
- int i;
-
- r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
- for (i = 0; i < q_vector->rxr_count; i++) {
- rx_ring = &(adapter->rx_ring[r_idx]);
- rx_ring->total_bytes = 0;
- rx_ring->total_packets = 0;
- r_idx = find_next_bit(q_vector->rxr_idx, adapter->num_rx_queues,
- r_idx + 1);
- }
if (!q_vector->rxr_count)
return IRQ_HANDLED;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net] ixgbevf: Prevent RX/TX statistics getting reset to zero
2012-07-17 1:24 [net] ixgbevf: Prevent RX/TX statistics getting reset to zero Jeff Kirsher
@ 2012-07-17 5:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-07-17 5:45 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: narendra_k, netdev, gospo, sassmann
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 16 Jul 2012 18:24:41 -0700
> From: Narendra K <narendra_k@dell.com>
>
> The commit 4197aa7bb81877ebb06e4f2cc1b5fea2da23a7bd implements 64 bit
> per ring statistics. But the driver resets the 'total_bytes' and
> 'total_packets' from RX and TX rings in the RX and TX interrupt
> handlers to zero. This results in statistics being lost and user space
> reporting RX and TX statistics as zero. This patch addresses the
> issue by preventing the resetting of RX and TX ring statistics to
> zero.
>
> Signed-off-by: Narendra K <narendra_k@dell.com>
> Tested-by: Sibai Li <sibai.li@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-17 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-17 1:24 [net] ixgbevf: Prevent RX/TX statistics getting reset to zero Jeff Kirsher
2012-07-17 5:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).