From: Eric Dumazet <eric.dumazet@gmail.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 0/5] Long term PMTU/redirect storage in ipv4.
Date: Wed, 18 Jul 2012 09:30:48 +0200 [thread overview]
Message-ID: <1342596648.2626.1831.camel@edumazet-glaptop> (raw)
In-Reply-To: <alpine.LFD.2.00.1207181014050.1652@ja.ssi.bg>
On Wed, 2012-07-18 at 10:28 +0300, Julian Anastasov wrote:
> This is going to read all values in the chain
> before reaching daddr? Or may be FNHE_RECLAIM_DEPTH is
> small and nobody will increase it. May be I can create
> some func that searches daddr in chain instead. Do you still
> prefer to remove the first daddr check or it is only
> that the code is intended too much?
>
I would not bother, since real cost is the initial cache line miss.
Once you read one field, reading others is really fast.
> > + if (fnhe_daddr == daddr) {
>
> Also, do we need some rcu locking in
> __ip_rt_update_pmtu or may be ipv4_update_pmtu is
> called always under rcu lock?
Sorry, I dont understand, we use the full lock
write_seqlock_bh(&fnhe_seqlock);/write_sequnlock_bh(&fnhe_seqlock);
next prev parent reply other threads:[~2012-07-18 7:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 13:14 [PATCH 0/5] Long term PMTU/redirect storage in ipv4 David Miller
2012-07-17 18:03 ` David Miller
2012-07-18 4:58 ` net-next and IPv6 Eric Dumazet
2012-07-18 7:04 ` Eric Dumazet
2012-07-18 7:23 ` Eric Dumazet
2012-07-18 7:38 ` [PATCH net-next] ipv6: fix inet6_csk_xmit() Eric Dumazet
2012-07-18 16:00 ` David Miller
2012-07-17 20:41 ` [PATCH 0/5] Long term PMTU/redirect storage in ipv4 Julian Anastasov
2012-07-17 20:46 ` David Miller
2012-07-17 22:14 ` Julian Anastasov
2012-07-17 22:09 ` David Miller
2012-07-18 1:06 ` Julian Anastasov
2012-07-18 3:46 ` Eric Dumazet
2012-07-18 7:28 ` Julian Anastasov
2012-07-18 7:30 ` Eric Dumazet [this message]
2012-07-18 8:36 ` Julian Anastasov
2012-07-18 16:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1342596648.2626.1831.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox