From: Steven Whitehouse <swhiteho@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] decnet: Don't set RTCF_DIRECTSRC.
Date: Tue, 24 Jul 2012 09:14:04 +0100 [thread overview]
Message-ID: <1343117644.2712.1.camel@menhir> (raw)
In-Reply-To: <20120723.131739.2064070169913079873.davem@davemloft.net>
Hi,
On Mon, 2012-07-23 at 13:17 -0700, David Miller wrote:
> It's an ipv4 defined route flag, and only ipv4 uses it.
>
This flag was really just being used to tag cached (direct) routes for
debugging purposes, so looks good to me.
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/decnet/dn_route.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index 23cc11d..85a3604 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
> /* Packet was intra-ethernet, so we know its on-link */
> if (cb->rt_flags & DN_RT_F_IE) {
> gateway = cb->src;
> - flags |= RTCF_DIRECTSRC;
> goto make_route;
> }
>
> @@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
>
> /* Close eyes and pray */
> gateway = cb->src;
> - flags |= RTCF_DIRECTSRC;
> goto make_route;
> default:
> goto e_inval;
prev parent reply other threads:[~2012-07-24 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 20:17 [PATCH] decnet: Don't set RTCF_DIRECTSRC David Miller
2012-07-24 8:14 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343117644.2712.1.camel@menhir \
--to=swhiteho@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).