* [PATCH] decnet: Don't set RTCF_DIRECTSRC.
@ 2012-07-23 20:17 David Miller
2012-07-24 8:14 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2012-07-23 20:17 UTC (permalink / raw)
To: netdev
It's an ipv4 defined route flag, and only ipv4 uses it.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/decnet/dn_route.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 23cc11d..85a3604 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
/* Packet was intra-ethernet, so we know its on-link */
if (cb->rt_flags & DN_RT_F_IE) {
gateway = cb->src;
- flags |= RTCF_DIRECTSRC;
goto make_route;
}
@@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
/* Close eyes and pray */
gateway = cb->src;
- flags |= RTCF_DIRECTSRC;
goto make_route;
default:
goto e_inval;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] decnet: Don't set RTCF_DIRECTSRC.
2012-07-23 20:17 [PATCH] decnet: Don't set RTCF_DIRECTSRC David Miller
@ 2012-07-24 8:14 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2012-07-24 8:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Hi,
On Mon, 2012-07-23 at 13:17 -0700, David Miller wrote:
> It's an ipv4 defined route flag, and only ipv4 uses it.
>
This flag was really just being used to tag cached (direct) routes for
debugging purposes, so looks good to me.
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Steve.
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/decnet/dn_route.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index 23cc11d..85a3604 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
> /* Packet was intra-ethernet, so we know its on-link */
> if (cb->rt_flags & DN_RT_F_IE) {
> gateway = cb->src;
> - flags |= RTCF_DIRECTSRC;
> goto make_route;
> }
>
> @@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
>
> /* Close eyes and pray */
> gateway = cb->src;
> - flags |= RTCF_DIRECTSRC;
> goto make_route;
> default:
> goto e_inval;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-24 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-23 20:17 [PATCH] decnet: Don't set RTCF_DIRECTSRC David Miller
2012-07-24 8:14 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).