From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] tcp: tcp_v4_early_demux() fixes
Date: Tue, 24 Jul 2012 13:05:36 +0200 [thread overview]
Message-ID: <1343127936.2626.11054.camel@edumazet-glaptop> (raw)
In-Reply-To: <1343126555.2626.11053.camel@edumazet-glaptop>
On Tue, 2012-07-24 at 12:42 +0200, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> 1) Remove a non needed pskb_may_pull() and fix a potential bug
> if skb->head was reallocated (iph & th pointers were not reloaded)
>
> TCP stack will pull/check headers anyway.
>
> 2) skb->dev->ifindex can be now replaced by skb->skb_iif
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv4/tcp_ipv4.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
I'll send a v2, a fix is also needed in ip_rcv_finish()
prev parent reply other threads:[~2012-07-24 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 10:42 [PATCH net-next] tcp: tcp_v4_early_demux() fixes Eric Dumazet
2012-07-24 11:05 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343127936.2626.11054.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox