From: Dan Williams <dcbw@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Olaf Hering <olaf@aepfle.de>,
"K. Y. Srinivasan" <kys@microsoft.com>,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, virtualization@lists.osdl.org,
apw@canonical.com, netdev@vger.kernel.org, ben@decadent.org.uk
Subject: Re: [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information
Date: Tue, 24 Jul 2012 13:36:50 -0500 [thread overview]
Message-ID: <1343155010.29196.1.camel@dcbw.foobar.com> (raw)
In-Reply-To: <20120724095659.5c869511@nehalam.linuxnetplumber.net>
On Tue, 2012-07-24 at 09:56 -0700, Stephen Hemminger wrote:
> On Tue, 24 Jul 2012 18:53:59 +0200
> Olaf Hering <olaf@aepfle.de> wrote:
>
> > On Tue, Jul 24, Stephen Hemminger wrote:
> >
> > > On Tue, 24 Jul 2012 09:01:34 -0700
> > > "K. Y. Srinivasan" <kys@microsoft.com> wrote:
> > >
> > > > + memset(cmd, 0, sizeof(cmd));
> > > > + strcat(cmd, "/sbin/ip -f inet route | grep -w ");
> > > > + strcat(cmd, if_name);
> > > > + strcat(cmd, " | awk '/default/ {print $3 }'");
> > >
> > >
> > > Much simpler method:
> > >
> > > ip route show match 0/0
> >
> > This also has the benefit that ip is not called with absolute path, now
> > that distros move binaries around.
> >
> > Olaf
>
> It is also not hard to do the same thing with a little function
> using libmnl
Yeah seriously, netlink anyone? You'll even get nicer error reporting
that way.
Dan
next prev parent reply other threads:[~2012-07-24 18:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 16:01 [PATCH 00/17] drivers: hv: kvp K. Y. Srinivasan
2012-07-24 15:54 ` Greg KH
2012-07-29 22:50 ` KY Srinivasan
2012-07-24 16:01 ` [PATCH 01/17] Drivers: hv: vmbus: Use the standard format string to format GUIDs K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 02/17] Drivers: hv: Add KVP definitions for IP address injection K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 03/17] Drivers: hv: kvp: Cleanup error handling in KVP K. Y. Srinivasan
2012-07-25 1:10 ` Ben Hutchings
2012-07-25 14:10 ` KY Srinivasan
2012-07-25 14:47 ` Ben Hutchings
2012-07-25 14:51 ` KY Srinivasan
2012-07-25 7:59 ` Olaf Hering
2012-07-24 16:01 ` [PATCH 04/17] Drivers: hv: kvp: Support the new IP injection messages K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 05/17] Tools: hv: Prepare to expand kvp_get_ip_address() functionality K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 06/17] Tools: hv: Further refactor kvp_get_ip_address() K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 07/17] Tools: hv: Gather address family information K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 08/17] Tools: hv: Gather subnet information K. Y. Srinivasan
2012-07-25 1:14 ` Ben Hutchings
2012-07-25 14:10 ` KY Srinivasan
2012-07-24 16:01 ` [PATCH 09/17] Tools: hv: Represent the ipv6 mask using CIDR notation K. Y. Srinivasan
2012-07-24 16:01 ` Borislav Petkov
2012-07-24 16:53 ` KY Srinivasan
2012-07-24 17:08 ` Borislav Petkov
2012-07-24 16:01 ` [PATCH 10/17] Tools: hv: Gather ipv[4,6] gateway information K. Y. Srinivasan
2012-07-24 16:29 ` Stephen Hemminger
2012-07-24 16:53 ` Olaf Hering
2012-07-24 16:56 ` Stephen Hemminger
2012-07-24 18:36 ` Dan Williams [this message]
2012-07-24 22:13 ` KY Srinivasan
2012-07-24 17:17 ` KY Srinivasan
2012-07-24 16:01 ` [PATCH 11/17] Tools: hv: Gather DNS information K. Y. Srinivasan
2012-07-24 23:38 ` Ben Hutchings
2012-07-24 16:01 ` [PATCH 12/17] Tools: hv: Gather DHCP information K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 13/17] Tools: hv: Implement the KVP verb - KVP_OP_SET_IP_INFO K. Y. Srinivasan
2012-07-25 1:24 ` Ben Hutchings
2012-07-25 14:48 ` KY Srinivasan
2012-07-30 17:33 ` Olaf Hering
2012-07-30 19:12 ` KY Srinivasan
2012-07-30 18:03 ` Olaf Hering
2012-07-30 18:32 ` KY Srinivasan
2012-07-30 19:19 ` Ben Hutchings
2012-07-31 10:34 ` KY Srinivasan
2012-07-24 16:01 ` [PATCH 14/17] Tools: hv: Rename the function kvp_get_ip_address() K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 15/17] Tools: hv: Implement the KVP verb - KVP_OP_GET_IP_INFO K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 16/17] Tools: hv: Get rid of some unused variables K. Y. Srinivasan
2012-07-24 16:01 ` [PATCH 17/17] Tools: hv: Correctly type string variables K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343155010.29196.1.camel@dcbw.foobar.com \
--to=dcbw@redhat.com \
--cc=apw@canonical.com \
--cc=ben@decadent.org.uk \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=shemminger@vyatta.com \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).