From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH RESEND net] net/mlx4_en: Limit the RFS filter IDs to be
 < RPS_NO_FILTER
Date: Wed, 25 Jul 2012 23:29:54 +0100
Message-ID: <1343255394.5132.145.camel@deadeye.wl.decadent.org.uk>
References: <1343226979-32004-1-git-send-email-ogerlitz@mellanox.com>
	 <1343228230.2694.12.camel@bwh-desktop.uk.solarflarecom.com>
	 <50100B03.2020205@mellanox.com>
	 <20120725.152337.155627167530086828.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: <ogerlitz@mellanox.com>, <netdev@vger.kernel.org>,
	<oren@mellanox.com>, <amirv@mellanox.com>
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from webmail.solarflare.com ([12.187.104.25]:50407 "EHLO
	ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751278Ab2GYW36 (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 25 Jul 2012 18:29:58 -0400
In-Reply-To: <20120725.152337.155627167530086828.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 2012-07-25 at 15:23 -0700, David Miller wrote:
> From: Or Gerlitz <ogerlitz@mellanox.com>
> Date: Wed, 25 Jul 2012 18:04:35 +0300
> 
> > On 25/07/2012 17:57, Ben Hutchings wrote:
> >>> @@ -77,12 +77,8 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv,
> >>> struct mlx4_en_cq *cq,
> >>>   	struct mlx4_en_dev *mdev = priv->mdev;
> >>>   	int err = 0;
> >>>   	char name[25];
> >>> -	struct cpu_rmap *rmap =
> >>> -#ifdef CONFIG_RFS_ACCEL
> >>> -		priv->dev->rx_cpu_rmap;
> >>> -#else
> >>> -		NULL;
> >>> -#endif
> >>> +	struct cpu_rmap *rmap = IS_ENABLED(CONFIG_RFS_ACCEL) ?
> >>> +		priv->dev->rx_cpu_rmap : NULL;
> >>
> >> This is a separate change.
> > 
> > OK, will send two patches
> 
> This change breaks the build.
> 
> You can't do this check at run-time, because the reason you need to
> check CONFIG_RFS_ACCEL is because if that's disabled then the netdev
> structure doesn't even have the ->rx_cpu_rmap member.

Yes, sorry for suggesting that, Or.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.