From: Joe Perches <joe@perches.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: acme@ghostprotocols.net, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]net:appletalk:ddp:fixed coding style issue in net/appletalk/ddp.c
Date: Thu, 26 Jul 2012 07:11:23 -0700 [thread overview]
Message-ID: <1343311883.11398.21.camel@joe2Laptop> (raw)
In-Reply-To: <1343311142-4539-1-git-send-email-ahiliation@yahoo.co.in>
On Thu, 2012-07-26 at 19:29 +0530, Jeffrin Jose wrote:
> Fixed coding style issue relating to switch and case
> statement in file net/appletalk/ddp.c
Don't just move the case labels, move the code blocks
including comments.
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -1798,7 +1798,7 @@ static int atalk_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
>
> switch (cmd) {
> /* Protocol layer */
> - case TIOCOUTQ: {
> + case TIOCOUTQ: {
> long amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
long amount = etc...
Post the patch with a commit message that says that
that a git diff -w is empty and the compiled objects
are the same too.
prev parent reply other threads:[~2012-07-26 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 13:59 [PATCH]net:appletalk:ddp:fixed coding style issue in net/appletalk/ddp.c Jeffrin Jose
2012-07-26 14:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343311883.11398.21.camel@joe2Laptop \
--to=joe@perches.com \
--cc=acme@ghostprotocols.net \
--cc=ahiliation@yahoo.co.in \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).