From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: bjorn@mork.no, netdev@vger.kernel.org
Subject: Re: open sockets preventing unregister_netdevice from completing in linux-next (next-20120724)
Date: Thu, 26 Jul 2012 19:15:28 +0200 [thread overview]
Message-ID: <1343322928.2626.11764.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120725.151737.1807149851147342859.davem@davemloft.net>
On Wed, 2012-07-25 at 15:17 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 25 Jul 2012 16:38:48 +0200
>
> > Yes, we miss what was done with rt_cache_flush() : find all cached
> > routes and release all dev references...
>
> We can fix this with a two-pronged approach:
>
> 1) Walk the FIB info nexthops and invalidate.
>
> 2) Entries not cached in the FIB info nexthops go into a
> per-netns list which is scanned as well.
>
> I'll try to work on this if nobody beats me to it.
With your latest patch, I can "rmmod tg3" while sockets are active.
Not sure we need all this now ?
(the trick is probably in fib_semantics.c, when you changed
dst_release() to dst_free())
next prev parent reply other threads:[~2012-07-26 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 13:45 open sockets preventing unregister_netdevice from completing in linux-next (next-20120724) Bjørn Mork
2012-07-25 14:38 ` Eric Dumazet
2012-07-25 22:17 ` David Miller
2012-07-26 17:15 ` Eric Dumazet [this message]
2012-07-26 21:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343322928.2626.11764.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox