From: Joe Perches <joe@perches.com>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: acme@ghostprotocols.net, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net:appletalk:ddp:fixed some codystyle issues in
Date: Sat, 28 Jul 2012 07:26:33 -0700 [thread overview]
Message-ID: <1343485593.2009.8.camel@joe2Laptop> (raw)
In-Reply-To: <1343472307-4697-1-git-send-email-ahiliation@yahoo.co.in>
On Sat, 2012-07-28 at 16:15 +0530, Jeffrin Jose wrote:
> Fixed coding style issues relating to indentation found in
> net/appletalkddp.c."git diff -w" is empty and the compiled objects
> are the same too.
Hello Jeffrin.
Your commit message is OK but your patch not.
The switch/case that could use modification is at
line 1790, not at line 685.
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -337,7 +337,7 @@ static int atif_proxy_probe_device(struct atalk_iface *atif,
>
> return -EADDRINUSE; /* Network is full... */
> }
> -
> +
Adding whitespace
> struct atalk_addr *atalk_find_dev_addr(struct net_device *dev)
> {
> @@ -685,26 +685,26 @@ static int atif_ioctl(int cmd, void __user *arg)
>
> switch (cmd) {
> case SIOCSIFADDR:
> - if (!capable(CAP_NET_ADMIN))
> + if (!capable(CAP_NET_ADMIN))
There's nothing wrong here to fix and you are
adding incorrect indentation.
Please try again and make sure you verify your
proposed patches by using scripts/checkpatch.pl
before submitting them.
prev parent reply other threads:[~2012-07-28 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 10:45 [PATCH] net:appletalk:ddp:fixed some codystyle issues in Jeffrin Jose
2012-07-28 14:26 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343485593.2009.8.camel@joe2Laptop \
--to=joe@perches.com \
--cc=acme@ghostprotocols.net \
--cc=ahiliation@yahoo.co.in \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).