From: Joe Perches <joe@perches.com>
To: Philipp Kern <pkern@debian.org>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, ak@linux.intel.com
Subject: Re: [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG
Date: Sat, 28 Jul 2012 10:29:20 -0700 [thread overview]
Message-ID: <1343496560.2009.15.camel@joe2Laptop> (raw)
In-Reply-To: <1343487997-9047-1-git-send-email-pkern@debian.org>
On Sat, 2012-07-28 at 17:06 +0200, Philipp Kern wrote:
> ip6_xmit checks if the outgoing packet is larger than the path MTU and
> emits ICMPv6 packet too big locally if this is the case. Logging this,
> even at KERN_DEBUG, confuses users. It is also not actually helpful for
> debugging, given that there is no reference to the connection that
> triggered this event.
[]
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
[]
> @@ -241,7 +241,7 @@ int ip6_xmit(struct sock *sk, struct sk_buff *skb, struct flowi6 *fl6,
> dst->dev, dst_output);
> }
>
> - net_dbg_ratelimited("IPv6: sending pkt_too_big to self\n");
> + LIMIT_NETDEBUG("IPv6: sending pkt_too_big to self\n");
LIMIT_NETDEBUG doesn't include a logging level.
Add a KERN_DEBUG prefix or another KERN_<LEVEL>.
Maybe it'd be better to add the context too.
next prev parent reply other threads:[~2012-07-28 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 15:06 [PATCH] net: move "IPv6: sending pkt_too_big to self" to NETDEBUG Philipp Kern
2012-07-28 17:29 ` Joe Perches [this message]
2012-07-29 12:24 ` Philipp Kern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343496560.2009.15.camel@joe2Laptop \
--to=joe@perches.com \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkern@debian.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox