From: Devendra Naga <develkernel412222@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
David Howells <dhowells@redhat.com>,
Jiri Pirko <jpirko@redhat.com>,
Pradeep A Dalvi <netdev@pradeepdalvi.com>,
netdev@vger.kernel.org
Cc: Devendra Naga <develkernel412222@gmail.com>
Subject: [PATCH] seeq: use PTR_RET at init_module of driver
Date: Sun, 29 Jul 2012 19:13:47 +0545 [thread overview]
Message-ID: <1343568527-12729-1-git-send-email-develkernel412222@gmail.com> (raw)
the driver sees wether the dev_seeq pointer is having a error that can be
read by using the PTR_ERR, and returns it at error case, other wise 0 at
success case.
the PTR_RET does the same thing, and use PTR_RET instead of redoing the
code of PTR_RET
Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
---
This patch is actually made by using coccinelle, and also by looking
at the PTR_RET function.
as its implementation is
static int PTR_RET(void *ptr)
{
if (IS_ERR(ptr)
return PTR_ERR(ptr);
return 0;
}
by using this i removed the following code and replaced with PTR_RET....
drivers/net/ethernet/seeq/seeq8005.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/seeq/seeq8005.c b/drivers/net/ethernet/seeq/seeq8005.c
index 698edbb..d6e50de 100644
--- a/drivers/net/ethernet/seeq/seeq8005.c
+++ b/drivers/net/ethernet/seeq/seeq8005.c
@@ -736,9 +736,7 @@ MODULE_PARM_DESC(irq, "SEEQ 8005 IRQ number");
int __init init_module(void)
{
dev_seeq = seeq8005_probe(-1);
- if (IS_ERR(dev_seeq))
- return PTR_ERR(dev_seeq);
- return 0;
+ return PTR_RET(dev_seeq);
}
void __exit cleanup_module(void)
--
1.7.9.5
next reply other threads:[~2012-07-29 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-29 13:28 Devendra Naga [this message]
2012-07-29 17:41 ` [PATCH] seeq: use PTR_RET at init_module of driver David Howells
2012-07-29 21:34 ` Jiri Pirko
2012-07-30 6:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343568527-12729-1-git-send-email-develkernel412222@gmail.com \
--to=develkernel412222@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).