From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net 1/2] tcp: Limit number of segments generated by GSO per skb Date: Mon, 30 Jul 2012 23:20:57 +0100 Message-ID: <1343686857.2667.60.camel@bwh-desktop.uk.solarflarecom.com> References: <1343668602.2667.6.camel@bwh-desktop.uk.solarflarecom.com> <1343669507.21269.33.camel@edumazet-glaptop> <1343676952.2667.26.camel@bwh-desktop.uk.solarflarecom.com> <20120730.144632.478408817308488569.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , , To: David Miller Return-path: Received: from webmail.solarflare.com ([12.187.104.25]:57692 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755105Ab2G3WVB (ORCPT ); Mon, 30 Jul 2012 18:21:01 -0400 In-Reply-To: <20120730.144632.478408817308488569.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-07-30 at 14:46 -0700, David Miller wrote: > From: Ben Hutchings > Date: Mon, 30 Jul 2012 20:35:52 +0100 > > > On Mon, 2012-07-30 at 19:31 +0200, Eric Dumazet wrote: > >> Or you could introduce a new wk->sk_gso_max_segments, that your sfc > >> driver sets to whatever limit ? > > > > Yes, that's another option. > > This is how I want this handled. How should that be applied in the GRO-forwarding case? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.