From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<netdev@vger.kernel.org>, <linux-net-drivers@solarflare.com>
Subject: Re: [PATCH net 1/2] tcp: Limit number of segments generated by GSO per skb
Date: Tue, 31 Jul 2012 00:07:58 +0100 [thread overview]
Message-ID: <1343689678.2667.63.camel@bwh-desktop.uk.solarflarecom.com> (raw)
In-Reply-To: <20120730155026.7460a9a6@nehalam.linuxnetplumber.net>
On Mon, 2012-07-30 at 15:50 -0700, Stephen Hemminger wrote:
> On Mon, 30 Jul 2012 23:20:57 +0100
> Ben Hutchings <bhutchings@solarflare.com> wrote:
>
> > On Mon, 2012-07-30 at 14:46 -0700, David Miller wrote:
> > > From: Ben Hutchings <bhutchings@solarflare.com>
> > > Date: Mon, 30 Jul 2012 20:35:52 +0100
> > >
> > > > On Mon, 2012-07-30 at 19:31 +0200, Eric Dumazet wrote:
> > > >> Or you could introduce a new wk->sk_gso_max_segments, that your sfc
> > > >> driver sets to whatever limit ?
> > > >
> > > > Yes, that's another option.
> > >
> > > This is how I want this handled.
> >
> > How should that be applied in the GRO-forwarding case?
> >
> > Ben.
> >
> Why not make max_frags a property of the device?
[...]
This has nothing to do with the number of input fragments. But I think
you're on the right track - this can be checked in netif_skb_features()
or something like that.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-07-30 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 17:14 [PATCH net 0/2] Prevent extreme TSO parameters from stalling TX queues Ben Hutchings
2012-07-30 17:16 ` [PATCH net 1/2] tcp: Limit number of segments generated by GSO per skb Ben Hutchings
2012-07-30 17:23 ` Ben Greear
2012-07-30 19:41 ` Ben Hutchings
2012-07-30 21:00 ` Ben Greear
2012-07-30 17:31 ` Eric Dumazet
2012-07-30 19:35 ` Ben Hutchings
2012-07-30 19:56 ` Ben Hutchings
2012-07-30 21:46 ` David Miller
2012-07-30 22:20 ` Ben Hutchings
2012-07-30 22:50 ` Stephen Hemminger
2012-07-30 23:07 ` Ben Hutchings [this message]
2012-07-30 17:17 ` [PATCH net 2/2] sfc: Correct the minimum TX queue size Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343689678.2667.63.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox