From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-net-drivers@solarflare.com>,
Ben Greear <greearb@candelatech.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: [PATCHv2 net 0/3] Prevent extreme TSO parameters from stalling TX queues
Date: Tue, 31 Jul 2012 02:51:16 +0100 [thread overview]
Message-ID: <1343699476.2667.69.camel@bwh-desktop.uk.solarflarecom.com> (raw)
The following changes fix a potential DoS by peers or local users on
network interfaces using the sfc driver (and possibly others) with TSO
enabled (as it is by default).
Please apply patches 1 and 2 to the net tree and your stable update
queue. I'm not sure whether patch 3 is really important.
Ben.
Ben Hutchings (3):
net: Allow driver to limit number of GSO segments per skb
sfc: Fix maximum number of TSO segments and minimum TX queue size
tcp: Apply device TSO segment limit earlier
drivers/net/ethernet/sfc/efx.c | 6 ++++++
drivers/net/ethernet/sfc/efx.h | 14 ++++++++++----
drivers/net/ethernet/sfc/ethtool.c | 16 +++++++++++-----
drivers/net/ethernet/sfc/tx.c | 19 +++++++++++++++++++
include/linux/netdevice.h | 2 ++
include/net/sock.h | 2 ++
net/core/dev.c | 4 ++++
net/core/sock.c | 1 +
net/ipv4/tcp.c | 4 +++-
net/ipv4/tcp_cong.c | 3 ++-
net/ipv4/tcp_output.c | 21 ++++++++++++---------
11 files changed, 72 insertions(+), 20 deletions(-)
--
1.7.7.6
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next reply other threads:[~2012-07-31 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 1:51 Ben Hutchings [this message]
2012-07-31 1:57 ` [PATCHv2 net 1/3] net: Allow driver to limit number of GSO segments per skb Ben Hutchings
2012-07-31 1:57 ` [PATCHv2 net 2/3] sfc: Fix maximum number of TSO segments and minimum TX queue size Ben Hutchings
2012-07-31 2:11 ` [PATCHv2 net 3/3] tcp: Apply device TSO segment limit earlier Ben Hutchings
2012-08-02 7:20 ` [PATCHv2 net 0/3] Prevent extreme TSO parameters from stalling TX queues David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343699476.2667.69.camel@bwh-desktop.uk.solarflarecom.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=greearb@candelatech.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox