* [BUG] igb: panic at boot time with latest Linus tree @ 2012-07-31 6:14 Eric Dumazet 2012-07-31 6:26 ` Jeff Kirsher 0 siblings, 1 reply; 4+ messages in thread From: Eric Dumazet @ 2012-07-31 6:14 UTC (permalink / raw) To: David Miller, Jeff Kirsher; +Cc: netdev For information, I get this each time I boot on latest Linus tree : RTNL is left locked, so machine unusable. No problem with David net tree, so thats a bit strange... Not sure I'll have time to investigate today (And tomorrow I am off for the day) [ 11.153682] BUG: unable to handle kernel NULL pointer dereference at (null) [ 11.153806] IP: [< (null)>] (null) [ 11.153872] PGD 310544067 PUD 311b2d067 PMD 0 [ 11.153945] Oops: 0010 [#1] SMP [ 11.154012] Modules linked in: nfsd exportfs nfs lockd auth_rpcgss sunrpc asix usbnet rt61pci crc_itu_t rt2x00pci rt2x00lib eeprom_93cx6 tg3 ixgbe mdio igb [ 11.154227] CPU 10 [ 11.154239] Pid: 2476, comm: NetworkManager Not tainted 3.5.0+ #123 Hewlett-Packard HP Z600 Workstation/0B54h [ 11.154437] RIP: 0010:[<0000000000000000>] [< (null)>] (null) [ 11.154574] RSP: 0018:ffff88030f667630 EFLAGS: 00010282 [ 11.154645] RAX: 0000000017cf7980 RBX: ffff88031080f100 RCX: 0000000000000200 [ 11.154720] RDX: 0000000000000040 RSI: ffffea0017cf7980 RDI: ffff880611bc1098 [ 11.154794] RBP: ffff88030f667678 R08: 0000000000000002 R09: 0000000000000000 [ 11.154868] R10: ffffea0017cf7980 R11: 0000000000000000 R12: ffffc90007d58000 [ 11.154942] R13: ffff880611bc1098 R14: ffff8803106ff000 R15: ffff8805f3de6040 [ 11.155016] FS: 00007fa2e4b94800(0000) GS:ffff88061fc80000(0000) knlGS:0000000000000000 [ 11.155148] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 11.155220] CR2: 0000000000000000 CR3: 000000031066a000 CR4: 00000000000007e0 [ 11.155283] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 11.155347] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 [ 11.155411] Process NetworkManager (pid: 2476, threadinfo ffff88030f666000, task ffff880310dd2d00) [ 11.155523] Stack: [ 11.155579] ffffffffa00071fe 0000000000000000 00ffff00a000400a ffff88030f667678 [ 11.155712] ffff88030f610700 0000000000000001 ffff88030f610708 ffff88030f610740 [ 11.155840] 0000000000000001 ffff88030f6676b8 ffffffffa000834b ffff88030f610700 [ 11.155969] Call Trace: [ 11.156036] [<ffffffffa00071fe>] ? igb_alloc_rx_buffers+0x13e/0x2d0 [igb] [ 11.156104] [<ffffffffa000834b>] igb_configure+0x34b/0x4d0 [igb] [ 11.156170] [<ffffffffa0008572>] __igb_open+0xa2/0x510 [igb] [ 11.156237] [<ffffffff812c0731>] ? find_next_bit+0x21/0xd0 [ 11.156303] [<ffffffffa0008b50>] igb_open+0x10/0x20 [igb] [ 11.156369] [<ffffffff8155288f>] __dev_open+0x8f/0xe0 [ 11.156432] [<ffffffff81552b31>] __dev_change_flags+0xa1/0x180 [ 11.156495] [<ffffffff81552cc8>] dev_change_flags+0x28/0x70 [ 11.156559] [<ffffffff8155f664>] do_setlink+0x284/0x9e0 [ 11.156624] [<ffffffff81560c8a>] ? rtnl_fill_ifinfo+0x92a/0xb30 [ 11.156690] [<ffffffff812cc220>] ? nla_parse+0x30/0xe0 [ 11.156755] [<ffffffff81561b35>] rtnl_newlink+0x345/0x580 [ 11.156820] [<ffffffff812655b9>] ? selinux_capable+0x39/0x50 [ 11.156885] [<ffffffff81262538>] ? security_capable+0x18/0x20 [ 11.156948] [<ffffffff81561384>] rtnetlink_rcv_msg+0x124/0x310 [ 11.157012] [<ffffffff8113794b>] ? kfree+0x3b/0x160 [ 11.157074] [<ffffffff81561260>] ? __rtnl_unlock+0x20/0x20 [ 11.157137] [<ffffffff8157a569>] netlink_rcv_skb+0xa9/0xd0 [ 11.157200] [<ffffffff8155ed55>] rtnetlink_rcv+0x25/0x40 [ 11.157262] [<ffffffff81579f4d>] netlink_unicast+0x1ad/0x230 [ 11.157326] [<ffffffff8157a286>] netlink_sendmsg+0x2b6/0x310 [ 11.157396] [<ffffffff815381ac>] sock_sendmsg+0xdc/0xf0 [ 11.157459] [<ffffffff8153aab8>] ? move_addr_to_kernel+0x68/0xb0 [ 11.157526] [<ffffffff81539b12>] __sys_sendmsg+0x392/0x3a0 [ 11.157590] [<ffffffff81118bbe>] ? handle_mm_fault+0x13e/0x210 [ 11.157656] [<ffffffff81155008>] ? __d_free+0x48/0x70 [ 11.157720] [<ffffffff8115e616>] ? mntput+0x26/0x40 [ 11.157783] [<ffffffff81140371>] ? __fput+0x191/0x250 [ 11.157846] [<ffffffff8153b809>] sys_sendmsg+0x49/0x90 [ 11.157911] [<ffffffff816ca652>] system_call_fastpath+0x16/0x1b [ 11.157973] Code: Bad RIP value. [ 11.158041] RIP [< (null)>] (null) [ 11.158106] RSP <ffff88030f667630> [ 11.158163] CR2: 0000000000000000 [ 11.158227] ---[ end trace bbfaed088efd61cb ]--- [ 11.158300] NetworkManager (2476) used greatest stack depth: 2936 bytes left ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] igb: panic at boot time with latest Linus tree 2012-07-31 6:14 [BUG] igb: panic at boot time with latest Linus tree Eric Dumazet @ 2012-07-31 6:26 ` Jeff Kirsher 2012-07-31 8:42 ` Eric Dumazet 0 siblings, 1 reply; 4+ messages in thread From: Jeff Kirsher @ 2012-07-31 6:26 UTC (permalink / raw) To: Eric Dumazet; +Cc: David Miller, netdev [-- Attachment #1: Type: text/plain, Size: 7783 bytes --] On Tue, 2012-07-31 at 08:14 +0200, Eric Dumazet wrote: > For information, I get this each time I boot on latest Linus tree : > > RTNL is left locked, so machine unusable. > > No problem with David net tree, so thats a bit strange... > > Not sure I'll have time to investigate today > (And tomorrow I am off for the day) > > [ 11.153682] BUG: unable to handle kernel NULL pointer dereference at (null) > [ 11.153806] IP: [< (null)>] (null) > [ 11.153872] PGD 310544067 PUD 311b2d067 PMD 0 > [ 11.153945] Oops: 0010 [#1] SMP > [ 11.154012] Modules linked in: nfsd exportfs nfs lockd auth_rpcgss sunrpc asix usbnet rt61pci crc_itu_t rt2x00pci rt2x00lib eeprom_93cx6 tg3 ixgbe mdio igb > [ 11.154227] CPU 10 > [ 11.154239] Pid: 2476, comm: NetworkManager Not tainted 3.5.0+ #123 Hewlett-Packard HP Z600 Workstation/0B54h > [ 11.154437] RIP: 0010:[<0000000000000000>] [< (null)>] (null) > [ 11.154574] RSP: 0018:ffff88030f667630 EFLAGS: 00010282 > [ 11.154645] RAX: 0000000017cf7980 RBX: ffff88031080f100 RCX: 0000000000000200 > [ 11.154720] RDX: 0000000000000040 RSI: ffffea0017cf7980 RDI: ffff880611bc1098 > [ 11.154794] RBP: ffff88030f667678 R08: 0000000000000002 R09: 0000000000000000 > [ 11.154868] R10: ffffea0017cf7980 R11: 0000000000000000 R12: ffffc90007d58000 > [ 11.154942] R13: ffff880611bc1098 R14: ffff8803106ff000 R15: ffff8805f3de6040 > [ 11.155016] FS: 00007fa2e4b94800(0000) GS:ffff88061fc80000(0000) knlGS:0000000000000000 > [ 11.155148] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 11.155220] CR2: 0000000000000000 CR3: 000000031066a000 CR4: 00000000000007e0 > [ 11.155283] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 11.155347] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > [ 11.155411] Process NetworkManager (pid: 2476, threadinfo ffff88030f666000, task ffff880310dd2d00) > [ 11.155523] Stack: > [ 11.155579] ffffffffa00071fe 0000000000000000 00ffff00a000400a ffff88030f667678 > [ 11.155712] ffff88030f610700 0000000000000001 ffff88030f610708 ffff88030f610740 > [ 11.155840] 0000000000000001 ffff88030f6676b8 ffffffffa000834b ffff88030f610700 > [ 11.155969] Call Trace: > [ 11.156036] [<ffffffffa00071fe>] ? igb_alloc_rx_buffers+0x13e/0x2d0 [igb] > [ 11.156104] [<ffffffffa000834b>] igb_configure+0x34b/0x4d0 [igb] > [ 11.156170] [<ffffffffa0008572>] __igb_open+0xa2/0x510 [igb] > [ 11.156237] [<ffffffff812c0731>] ? find_next_bit+0x21/0xd0 > [ 11.156303] [<ffffffffa0008b50>] igb_open+0x10/0x20 [igb] > [ 11.156369] [<ffffffff8155288f>] __dev_open+0x8f/0xe0 > [ 11.156432] [<ffffffff81552b31>] __dev_change_flags+0xa1/0x180 > [ 11.156495] [<ffffffff81552cc8>] dev_change_flags+0x28/0x70 > [ 11.156559] [<ffffffff8155f664>] do_setlink+0x284/0x9e0 > [ 11.156624] [<ffffffff81560c8a>] ? rtnl_fill_ifinfo+0x92a/0xb30 > [ 11.156690] [<ffffffff812cc220>] ? nla_parse+0x30/0xe0 > [ 11.156755] [<ffffffff81561b35>] rtnl_newlink+0x345/0x580 > [ 11.156820] [<ffffffff812655b9>] ? selinux_capable+0x39/0x50 > [ 11.156885] [<ffffffff81262538>] ? security_capable+0x18/0x20 > [ 11.156948] [<ffffffff81561384>] rtnetlink_rcv_msg+0x124/0x310 > [ 11.157012] [<ffffffff8113794b>] ? kfree+0x3b/0x160 > [ 11.157074] [<ffffffff81561260>] ? __rtnl_unlock+0x20/0x20 > [ 11.157137] [<ffffffff8157a569>] netlink_rcv_skb+0xa9/0xd0 > [ 11.157200] [<ffffffff8155ed55>] rtnetlink_rcv+0x25/0x40 > [ 11.157262] [<ffffffff81579f4d>] netlink_unicast+0x1ad/0x230 > [ 11.157326] [<ffffffff8157a286>] netlink_sendmsg+0x2b6/0x310 > [ 11.157396] [<ffffffff815381ac>] sock_sendmsg+0xdc/0xf0 > [ 11.157459] [<ffffffff8153aab8>] ? move_addr_to_kernel+0x68/0xb0 > [ 11.157526] [<ffffffff81539b12>] __sys_sendmsg+0x392/0x3a0 > [ 11.157590] [<ffffffff81118bbe>] ? handle_mm_fault+0x13e/0x210 > [ 11.157656] [<ffffffff81155008>] ? __d_free+0x48/0x70 > [ 11.157720] [<ffffffff8115e616>] ? mntput+0x26/0x40 > [ 11.157783] [<ffffffff81140371>] ? __fput+0x191/0x250 > [ 11.157846] [<ffffffff8153b809>] sys_sendmsg+0x49/0x90 > [ 11.157911] [<ffffffff816ca652>] system_call_fastpath+0x16/0x1b > [ 11.157973] Code: Bad RIP value. > [ 11.158041] RIP [< (null)>] (null) > [ 11.158106] RSP <ffff88030f667630> > [ 11.158163] CR2: 0000000000000000 > [ 11.158227] ---[ end trace bbfaed088efd61cb ]--- > [ 11.158300] NetworkManager (2476) used greatest stack depth: 2936 bytes left > > I have an igb patch current in test to fix a panic in igb. Here is the patch: From: Emil Tantilov <emil.s.tantilov@intel.com> Subject: igb: fix panic while dumping packets on Tx hang with IOMMU This patch resolves a "BUG: unable to handle kernel paging request at ..." oops while dumping packet data. The issue occurs with IOMMU enabled due to the address provided by phys_to_virt(). This patch avoids phys_to_virt() by making using skb->data and the address of the pages allocated for Rx. Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 447e131..8d7e5da 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -462,10 +462,10 @@ static void igb_dump(struct igb_adapter *adapter) (u64)buffer_info->time_stamp, buffer_info->skb, next_desc); - if (netif_msg_pktdata(adapter) && buffer_info->dma != 0) + if (netif_msg_pktdata(adapter) && buffer_info->skb) print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS, - 16, 1, phys_to_virt(buffer_info->dma), + 16, 1, buffer_info->skb->data, buffer_info->length, true); } } @@ -547,18 +547,17 @@ rx_ring_summary: (u64)buffer_info->dma, buffer_info->skb, next_desc); - if (netif_msg_pktdata(adapter)) { + if (netif_msg_pktdata(adapter) && + buffer_info->dma && buffer_info->skb) { print_hex_dump(KERN_INFO, "", - DUMP_PREFIX_ADDRESS, - 16, 1, - phys_to_virt(buffer_info->dma), - IGB_RX_HDR_LEN, true); + DUMP_PREFIX_ADDRESS, + 16, 1, buffer_info->skb->data, + IGB_RX_HDR_LEN, true); print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS, 16, 1, - phys_to_virt( - buffer_info->page_dma + - buffer_info->page_offset), + page_address(buffer_info->page) + + buffer_info->page_offset, PAGE_SIZE/2, true); } } [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [BUG] igb: panic at boot time with latest Linus tree 2012-07-31 6:26 ` Jeff Kirsher @ 2012-07-31 8:42 ` Eric Dumazet 2012-07-31 8:51 ` Jeff Kirsher 0 siblings, 1 reply; 4+ messages in thread From: Eric Dumazet @ 2012-07-31 8:42 UTC (permalink / raw) To: jeffrey.t.kirsher; +Cc: David Miller, netdev On Mon, 2012-07-30 at 23:26 -0700, Jeff Kirsher wrote: > On Tue, 2012-07-31 at 08:14 +0200, Eric Dumazet wrote: > > For information, I get this each time I boot on latest Linus tree : > > > > RTNL is left locked, so machine unusable. > > > > No problem with David net tree, so thats a bit strange... > > > > Not sure I'll have time to investigate today > > (And tomorrow I am off for the day) > > > > > > > > I have an igb patch current in test to fix a panic in igb. Here is the > patch: > Ah sorry for the false alarm, it appears I had igb module in a out of date initrd file (coming from my net tree) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [BUG] igb: panic at boot time with latest Linus tree 2012-07-31 8:42 ` Eric Dumazet @ 2012-07-31 8:51 ` Jeff Kirsher 0 siblings, 0 replies; 4+ messages in thread From: Jeff Kirsher @ 2012-07-31 8:51 UTC (permalink / raw) To: Eric Dumazet; +Cc: David Miller, netdev [-- Attachment #1: Type: text/plain, Size: 889 bytes --] On Tue, 2012-07-31 at 10:42 +0200, Eric Dumazet wrote: > On Mon, 2012-07-30 at 23:26 -0700, Jeff Kirsher wrote: > > On Tue, 2012-07-31 at 08:14 +0200, Eric Dumazet wrote: > > > For information, I get this each time I boot on latest Linus tree : > > > > > > RTNL is left locked, so machine unusable. > > > > > > No problem with David net tree, so thats a bit strange... > > > > > > Not sure I'll have time to investigate today > > > (And tomorrow I am off for the day) > > > > > > > > > > > > > I have an igb patch current in test to fix a panic in igb. Here is the > > patch: > > > > > > Ah sorry for the false alarm, it appears I had igb module in a out of date initrd file (coming from my net tree) No problem, thanks for the feedback. Whether or not it was false alarm, the feedback is always a good thing which helps us improve. Cheers, Jeff [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-31 8:51 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-31 6:14 [BUG] igb: panic at boot time with latest Linus tree Eric Dumazet 2012-07-31 6:26 ` Jeff Kirsher 2012-07-31 8:42 ` Eric Dumazet 2012-07-31 8:51 ` Jeff Kirsher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).