From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dmitry Kravkov" Subject: Re: [PATCH] bnx2x: fix mem leak when command is unknown Date: Wed, 1 Aug 2012 10:41:17 +0300 Message-ID: <1343806877.834.3.camel@lb-tlvb-dmitry.il.broadcom.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "Eilon Greenstein" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Jesper Juhl" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2012-07-31 at 23:39 +0200, Jesper Juhl wrote: > In bnx2x_mcast_enqueue_cmd() we'll leak the memory allocated to > 'new_cmd' if we hit the deafault case of the 'switch (cmd)'. > Add a 'kfree(new_cmd)' to that case to avoid the leak. > > Signed-off-by: Jesper Juhl > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 1 + > 1 file changed, 1 insertion(+) > > note: due to lack of hardware this patch is compile tested only. > > diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > index 734fd87..62f754b 100644 > --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c > @@ -2485,6 +2485,7 @@ static int bnx2x_mcast_enqueue_cmd(struct bnx2x *bp, > break; > > default: > + kfree(new_cmd); > BNX2X_ERR("Unknown command: %d\n", cmd); > return -EINVAL; > } > -- > 1.7.11.3 > Thanks a lot, Jesper. Acked-by: Dmitry Kravkov >