From: Jun Zhao <mypopydev@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ipv6 : ip6mr.c : Fix can't match the IPv6 multicast packets with input net device in netfilter FORWARD chain.
Date: Fri, 03 Aug 2012 15:10:58 +0800 [thread overview]
Message-ID: <1343977858.4579.11.camel@barry.localdomain> (raw)
In-Reply-To: <20120802.234311.2108069975669469931.davem@davemloft.net>
On Thu, 2012-08-02 at 23:43 -0700, David Miller wrote:
> From: Jun Zhao <mypopydev@gmail.com>
> Date: Fri, 3 Aug 2012 14:27:51 +0800
>
> > @@ -1960,7 +1962,7 @@ static int ip6mr_forward2(struct net *net, struct mr6_table *mrt,
> >
> > IP6CB(skb)->flags |= IP6SKB_FORWARDED;
> >
> > - return NF_HOOK(NFPROTO_IPV6, NF_INET_FORWARD, skb, skb->dev, dev,
> > + return NF_HOOK(NFPROTO_IPV6, NF_INET_FORWARD, skb, indev, dev,
> > ip6mr_forward2_finish);
> >
>
> This patch has the same problem I mentioned, it means someone who is
> now matching on the VIF device will now fail to do son.
>
> You have to understand that you simply cannot change the behavior
> here without breaking something for someone.
Hi, David:
Can you give me some more details what I break in this fix?
As my understanding, in the ip6mr_forward2(), vifi is the VIF index for
output, we can get the output device used vif->dev and record input
device before change skb->dev; then used FORWARD chain match the rules.
Tks.
prev parent reply other threads:[~2012-08-03 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 6:27 [PATCH v2 1/1] ipv6 : ip6mr.c : Fix can't match the IPv6 multicast packets with input net device in netfilter FORWARD chain Jun Zhao
2012-08-03 6:43 ` David Miller
2012-08-03 7:10 ` Jun Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343977858.4579.11.camel@barry.localdomain \
--to=mypopydev@gmail.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).