From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: ebiederm@xmission.com, xemul@parallels.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: Allow to create links with given ifindex
Date: Sat, 04 Aug 2012 09:10:40 +0200 [thread overview]
Message-ID: <1344064240.9299.1470.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120803.165611.1832423445730269834.davem@davemloft.net>
On Fri, 2012-08-03 at 16:56 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 03 Aug 2012 07:45:29 +0200
>
> > @@ -1587,13 +1587,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
> > if (ipv4_is_zeronet(daddr))
> > goto martian_destination;
> >
> > - if (likely(!IN_DEV_ROUTE_LOCALNET(in_dev))) {
> > - if (ipv4_is_loopback(daddr))
> > - goto martian_destination;
> > + if (ipv4_is_loopback(daddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
> > + goto martian_destination;
> >
> > - if (ipv4_is_loopback(saddr))
> > - goto martian_source;
> > - }
> > + if (ipv4_is_loopback(saddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
> > + goto martian_source;
>
> Maybe clearer as:
>
> if ((ipv4_is_loopback(daddr) || ipv4_is_loopback(saddr)) &&
> !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
> goto martian_source;
Clearer, but handling of a martian destination is different of the
martian source ;)
next prev parent reply other threads:[~2012-08-04 7:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 4:34 [PATCH 1/2] net: Allow to create links with given ifindex Pavel Emelyanov
2012-07-30 4:36 ` [PATCH 2/2] veth: Allow to create peer link " Pavel Emelyanov
2012-07-30 10:49 ` [PATCH 1/2] net: Allow to create links " Eric W. Biederman
2012-07-30 10:56 ` Eric W. Biederman
2012-07-31 9:03 ` Pavel Emelyanov
2012-07-31 11:58 ` Eric W. Biederman
2012-07-31 13:30 ` Pavel Emelyanov
2012-08-02 10:28 ` Eric Dumazet
2012-08-02 11:09 ` Eric W. Biederman
2012-08-02 23:37 ` David Miller
2012-08-02 23:26 ` David Miller
2012-08-03 5:45 ` Eric Dumazet
2012-08-03 5:51 ` Eric Dumazet
2012-08-03 23:56 ` David Miller
2012-08-04 7:10 ` Eric Dumazet [this message]
2012-08-04 8:25 ` David Miller
2012-07-30 11:51 ` Eric Dumazet
2012-07-30 12:33 ` Eric W. Biederman
2012-07-31 9:06 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344064240.9299.1470.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox