netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mISDN: Bugfix for layer2 fixed TEI mode
@ 2012-08-04 10:14 Karsten Keil
  2012-08-06 20:27 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Karsten Keil @ 2012-08-04 10:14 UTC (permalink / raw)
  To: netdev; +Cc: davem, stable, isdn4linux

If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
4 (TEI assigned). This was true only for Point to Point connections, but not
for the other fixed TEIs. It was not found before, because usually only the
TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
connections with SAPI 16, TEI 1, it did fail.

Signed-off-by: Karsten Keil <keil@b1-systems.de>
Cc: <stable@vger.kernel.org> # 3.5.x
---
 drivers/isdn/mISDN/layer2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index 0dc8abc..949cabb 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -2222,7 +2222,7 @@ create_l2(struct mISDNchannel *ch, u_int protocol, u_long options, int tei,
 	InitWin(l2);
 	l2->l2m.fsm = &l2fsm;
 	if (test_bit(FLG_LAPB, &l2->flag) ||
-	    test_bit(FLG_PTP, &l2->flag) ||
+	    test_bit(FLG_FIXED_TEI, &l2->flag) ||
 	    test_bit(FLG_LAPD_NET, &l2->flag))
 		l2->l2m.state = ST_L2_4;
 	else
-- 
1.7.7

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mISDN: Bugfix for layer2 fixed TEI mode
  2012-08-04 10:14 [PATCH] mISDN: Bugfix for layer2 fixed TEI mode Karsten Keil
@ 2012-08-06 20:27 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-08-06 20:27 UTC (permalink / raw)
  To: keil; +Cc: netdev, stable, isdn4linux

From: Karsten Keil <keil@b1-systems.de>
Date: Sat,  4 Aug 2012 12:14:25 +0200

> If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
> 4 (TEI assigned). This was true only for Point to Point connections, but not
> for the other fixed TEIs. It was not found before, because usually only the
> TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
> connections with SAPI 16, TEI 1, it did fail.
> 
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
> Cc: <stable@vger.kernel.org> # 3.5.x

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-06 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-04 10:14 [PATCH] mISDN: Bugfix for layer2 fixed TEI mode Karsten Keil
2012-08-06 20:27 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).