From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pavel Emelyanov <xemul@parallels.com>
Cc: David Miller <davem@davemloft.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH 5/5] net: Loopback ifindex is constant now
Date: Mon, 06 Aug 2012 13:54:31 +0200 [thread overview]
Message-ID: <1344254071.26674.15.camel@edumazet-glaptop> (raw)
In-Reply-To: <501F9D2B.8000504@parallels.com>
On Mon, 2012-08-06 at 14:32 +0400, Pavel Emelyanov wrote:
> As pointed out, there are places, that access net->loopback_dev->ifindex
> and after ifindex generation is made per-net this value becomes constant
> equals 1. So go ahead and introduce the LOOPBACK_IFINDEX constant and use
> it where appropriate.
>
> Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
What guarantee do we have that loopback is the first device per net ?
You should add this to the changelog because its not that obvious.
next prev parent reply other threads:[~2012-08-06 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 10:30 [PATCH net-next 0/5] Per-net and on-demand link indices (and related) Pavel Emelyanov
2012-08-06 10:30 ` [PATCH 1/5] net: Don't use ifindices in hash fns Pavel Emelyanov
2012-08-06 10:43 ` Eric Dumazet
2012-08-06 11:01 ` Pavel Emelyanov
2012-08-06 11:51 ` Eric Dumazet
2012-08-06 10:31 ` [PATCH 2/5] net: Allow to create links with given ifindex Pavel Emelyanov
2012-08-06 10:31 ` [PATCH 3/5] veth: Allow to create peer link " Pavel Emelyanov
2012-08-06 10:31 ` [PATCH 4/5] net: Make ifindex generation per-net namespace Pavel Emelyanov
2012-08-06 10:32 ` [PATCH 5/5] net: Loopback ifindex is constant now Pavel Emelyanov
2012-08-06 11:54 ` Eric Dumazet [this message]
2012-08-06 12:13 ` Pavel Emelyanov
-- strict thread matches above, loose matches on Subject: below --
2012-08-09 7:52 [PATCH net-next 0/5] Per-net and on-demand link indices (and related) v3 Pavel Emelyanov
2012-08-09 7:53 ` [PATCH 5/5] net: Loopback ifindex is constant now Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344254071.26674.15.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox