From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: Cong Wang <amwang@redhat.com>, David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: [Resend PATCH 7/8] bridge: add some comments for NETDEV_RELEASE
Date: Tue, 7 Aug 2012 13:59:09 +0800 [thread overview]
Message-ID: <1344319149-13132-1-git-send-email-amwang@redhat.com> (raw)
In-Reply-To: <20120806.135003.442648448779232464.davem@davemloft.net>
Add comments on why we don't notify NETDEV_RELEASE.
Cc: David Miller <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index 171fd6b..bf47d4f 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -427,6 +427,9 @@ int br_del_if(struct net_bridge *br, struct net_device *dev)
if (!p || p->br != br)
return -EINVAL;
+ /* We don't notify NETDEV_RELEASE event, as this will
+ * stop netconsole on the bridge.
+ */
del_nbp(p);
spin_lock_bh(&br->lock);
next prev parent reply other threads:[~2012-08-07 5:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 14:23 [PATCH v2 0/8] some netpoll and netconsole fixes Cong Wang
2012-08-06 14:23 ` [PATCH 1/8] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup() Cong Wang
2012-08-06 15:20 ` Eric Dumazet
2012-08-07 2:28 ` Cong Wang
2012-08-06 14:23 ` [PATCH 2/8] netpoll: make __netpoll_cleanup non-block Cong Wang
2012-08-06 14:23 ` [PATCH 3/8] netconsole: do not release spin_lock when calling __netpoll_cleanup Cong Wang
2012-08-06 14:23 ` [PATCH 4/8] netpoll: take rcu_read_lock_bh() in netpoll_rx() Cong Wang
2012-08-06 14:23 ` [PATCH 5/8] netpoll: use netpoll_rx_on() " Cong Wang
2012-08-06 14:23 ` [PATCH 6/8] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev() Cong Wang
2012-08-06 14:23 ` [PATCH 7/8] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-06 20:50 ` David Miller
2012-08-06 23:39 ` Joe Perches
2012-08-10 10:59 ` Jan Engelhardt
2012-08-10 11:13 ` Joe Perches
2012-08-07 2:27 ` Cong Wang
2012-08-07 5:59 ` Cong Wang [this message]
2012-08-07 7:10 ` [Resend PATCH " David Miller
2012-08-07 15:13 ` Cong Wang
2012-08-06 14:23 ` [PATCH 8/8] bridge: use list_for_each_entry() in netpoll functions Cong Wang
2012-08-11 18:07 ` Stephen Hemminger
2012-08-07 6:58 ` [PATCH v2 0/8] some netpoll and netconsole fixes Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344319149-13132-1-git-send-email-amwang@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).