Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: force dst_default_metrics to const section
Date: Wed, 08 Aug 2012 00:56:40 +0200	[thread overview]
Message-ID: <1344380200.28967.207.camel@edumazet-glaptop> (raw)
In-Reply-To: <1344379474.2688.89.camel@bwh-desktop.uk.solarflarecom.com>

On Tue, 2012-08-07 at 23:44 +0100, Ben Hutchings wrote:

> Any consideration of implementation details like BSS and cache line
> sharing is already outside of 'plain C'.  And you don't have to 'mess
> with all arches'; just look at what <linux/init.h> and <linux/module.h>
> do.

"const" is the clean and portable way to express my needs. No magic
section.

All is self-contained in the definition of the metrics, with a nice
comment.

All const are naturally shared by all cpus, without adding extra cache
line boundaries.

Please feel free to send another version, but I wont spend more time
myself.

Thanks

  reply	other threads:[~2012-08-07 22:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07 16:11 [PATCH] net: force dst_default_metrics to const section Eric Dumazet
2012-08-07 20:15 ` Ben Hutchings
2012-08-07 20:55   ` Eric Dumazet
2012-08-07 22:12     ` Ben Hutchings
2012-08-07 22:34       ` Eric Dumazet
2012-08-07 22:44         ` Ben Hutchings
2012-08-07 22:56           ` Eric Dumazet [this message]
2012-08-07 23:17             ` David Miller
2012-08-08 23:00     ` David Miller
2012-08-07 21:55   ` David Miller
2012-08-07 22:09     ` Eric Dumazet
2012-08-07 22:11       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344380200.28967.207.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox