From: Flavio Leitner <fbl@redhat.com>
To: netdev <netdev@vger.kernel.org>
Cc: Jay Vosburgh <fubar@us.ibm.com>,
Andy Gospodarek <andy@greyhouse.net>,
Leonardo Chiquitto <lchiquitto@suse.com>,
Flavio Leitner <fbl@redhat.com>
Subject: [net-next] bonding: don't allow the master to become its slave
Date: Thu, 9 Aug 2012 15:30:49 -0300 [thread overview]
Message-ID: <1344537049-11473-1-git-send-email-fbl@redhat.com> (raw)
It doesn't make any sense to allow the master to become
its slave. That creates a loop of events causing a crash.
Reported-by: Leonardo Chiquitto <lchiquitto@suse.com>
Signed-off-by: Flavio Leitner <fbl@redhat.com>
---
drivers/net/bonding/bond_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 6fae5f3..5407b44 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1505,6 +1505,11 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
int link_reporting;
int res = 0;
+ if (bond_dev == slave_dev) {
+ pr_err("%s: Error: cannot enslave itself.\n", bond_dev->name);
+ return -EINVAL;
+ }
+
if (!bond->params.use_carrier && slave_dev->ethtool_ops == NULL &&
slave_ops->ndo_do_ioctl == NULL) {
pr_warning("%s: Warning: no link monitoring support for %s\n",
--
1.7.11.2
next reply other threads:[~2012-08-09 18:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 18:30 Flavio Leitner [this message]
2012-08-09 18:45 ` [net-next] bonding: don't allow the master to become its slave Leonardo Chiquitto
2012-08-09 19:03 ` Ben Hutchings
2012-08-09 19:23 ` Jay Vosburgh
2012-08-09 19:39 ` Flavio Leitner
2012-08-09 19:55 ` Jiri Pirko
2012-08-09 20:52 ` Flavio Leitner
2012-08-09 21:09 ` Ben Hutchings
2012-08-09 21:27 ` Jay Vosburgh
2012-08-09 23:43 ` David Miller
2012-08-10 13:04 ` Jiri Pirko
2012-08-09 19:54 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344537049-11473-1-git-send-email-fbl@redhat.com \
--to=fbl@redhat.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=lchiquitto@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).