From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE
Date: Fri, 10 Aug 2012 10:38:06 +0800 [thread overview]
Message-ID: <1344566286.17296.4.camel@cr0> (raw)
In-Reply-To: <uiuqn4l019wk5s0l9cq2w0cy.1344541199595@email.android.com>
On Thu, 2012-08-09 at 09:44 -1000, Stephen Hemminger wrote:
> If you are going to add an explanation, then I would prefer a more complete one. Something like:
> "Since more than one interface can be attached to a bridge, there still maybe an alternate path for netconsole to use; therefore there is no reason for a NETDEV_RELEASE event."
Yeah, this is better.
>
> But my opinion it really isn't necessary to document what isn't done in the code, only what is done. The purpose of comments is to explain the wider impacts of the code.
The reason why I add it is to remind people like me who forgot the
reason behind. ;)
Thanks.
next prev parent reply other threads:[~2012-08-10 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 19:44 [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Stephen Hemminger
2012-08-10 2:38 ` Cong Wang [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-10 7:10 [PATCH v4 00/14] some netpoll and netconsole fixes Cong Wang
2012-08-10 7:10 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-09 15:00 [PATCH v3 0/14] some netpoll and netconsole fixes Cong Wang
2012-08-09 15:00 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344566286.17296.4.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).