Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jain Priyanka-B32167 <B32167@freescale.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Fan Du <fan.du@windriver.com>
Subject: RE: [PATCH][XFRM] Replace rwlock on xfrm_policy_afinfo with rcu
Date: Fri, 10 Aug 2012 08:26:32 +0200	[thread overview]
Message-ID: <1344579992.31104.1224.camel@edumazet-glaptop> (raw)
In-Reply-To: <AC83832D6324604BB08FAE5A33553F1907A9B368@039-SN2MPN1-012.039d.mgd.msft.net>

On Fri, 2012-08-10 at 04:28 +0000, Jain Priyanka-B32167 wrote:
> Hello Eric Dumazet,
> 
> Like Fan Du, even I could not see the bug in the current code. Can you please elaborate
> Yes, it might be invalid, but all the callers have checked the return value, thus use it in a sane way.
> So I don't follow "Note the current code is buggy as well".
> 
> Am I missing something here?
> 

Hmm, I misread the code, sorry for the false alarm.

      reply	other threads:[~2012-08-10  6:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  5:21 [PATCH][XFRM] Replace rwlock on xfrm_policy_afinfo with rcu Priyanka Jain
2012-08-07 23:21 ` David Miller
2012-08-08  4:53   ` Jain Priyanka-B32167
2012-08-08  5:55     ` David Miller
2012-08-08  9:41       ` Jain Priyanka-B32167
2012-08-08  6:25 ` Eric Dumazet
2012-08-08  6:44   ` Fan Du
2012-08-10  4:28     ` Jain Priyanka-B32167
2012-08-10  6:26       ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344579992.31104.1224.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=B32167@freescale.com \
    --cc=fan.du@windriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox