From: Cong Wang <amwang@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, Benjamin LaHaise <bcrl@kvack.org>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 11/14] vlan: clean up vlan_dev_hard_start_xmit()
Date: Fri, 10 Aug 2012 15:47:51 +0800 [thread overview]
Message-ID: <1344584871.29601.0.camel@cr0> (raw)
In-Reply-To: <Pine.GSO.4.63.1208100913090.13591@stinky-local.trash.net>
On Fri, 2012-08-10 at 09:14 +0200, Patrick McHardy wrote:
> On Fri, 10 Aug 2012, Cong Wang wrote:
> > static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
> > struct net_device *dev)
> > {
> > + struct vlan_dev_priv *info = vlan_dev_priv(dev);
>
> We're consistently using "vlan" for the private data throughout
> the code. Please keep it that way.
>
Ok, I will update it.
Thanks!
next prev parent reply other threads:[~2012-08-10 7:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 7:10 [PATCH v4 00/14] some netpoll and netconsole fixes Cong Wang
2012-08-10 7:10 ` [PATCH 01/14] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup() Cong Wang
2012-08-10 7:10 ` [PATCH 02/14] netpoll: make __netpoll_cleanup non-block Cong Wang
2012-08-10 7:10 ` [PATCH 03/14] netconsole: do not release spin_lock when calling __netpoll_cleanup Cong Wang
2012-08-10 7:10 ` [PATCH 04/14] netpoll: take rcu_read_lock_bh() in netpoll_rx() Cong Wang
2012-08-10 7:10 ` [PATCH 05/14] netpoll: use netpoll_rx_on() " Cong Wang
2012-08-10 7:10 ` [PATCH 06/14] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev() Cong Wang
2012-08-10 7:10 ` [PATCH 07/14] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-10 7:10 ` [PATCH 08/14] bridge: use list_for_each_entry() in netpoll functions Cong Wang
2012-08-10 7:10 ` [PATCH 09/14] netpoll: check netpoll tx status on the right device Cong Wang
2012-08-10 7:20 ` Jiri Pirko
2012-08-10 7:52 ` Cong Wang
2012-08-10 8:32 ` Jiri Pirko
2012-08-10 7:10 ` [PATCH 10/14] netpoll: convert several functions to bool Cong Wang
2012-08-10 7:10 ` [PATCH 11/14] vlan: clean up vlan_dev_hard_start_xmit() Cong Wang
2012-08-10 7:14 ` Patrick McHardy
2012-08-10 7:47 ` Cong Wang [this message]
2012-08-10 7:10 ` [PATCH 12/14] netpoll: handle vlan tags in netpoll tx and rx path Cong Wang
2012-08-10 7:10 ` [PATCH 13/14] netpoll: re-enable irq in poll_napi() Cong Wang
2012-08-10 7:10 ` [PATCH 14/14] netconsole.txt: revision of examples for the receiver of kernel messages Cong Wang
-- strict thread matches above, loose matches on Subject: below --
2012-08-09 15:00 [PATCH v3 0/14] some netpoll and netconsole fixes Cong Wang
2012-08-09 15:00 ` [PATCH 11/14] vlan: clean up vlan_dev_hard_start_xmit() Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344584871.29601.0.camel@cr0 \
--to=amwang@redhat.com \
--cc=bcrl@kvack.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).