From: Joe Perches <joe@perches.com>
To: Jan Engelhardt <jengelh@inai.de>
Cc: David Miller <davem@davemloft.net>,
amwang@redhat.com, netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH 7/8] bridge: add some comments for NETDEV_RELEASE
Date: Fri, 10 Aug 2012 04:13:18 -0700 [thread overview]
Message-ID: <1344597198.2338.9.camel@joe2Laptop> (raw)
In-Reply-To: <alpine.LNX.2.01.1208101257010.10147@frira.zrqbmnf.qr>
On Fri, 2012-08-10 at 12:59 +0200, Jan Engelhardt wrote:
> On Tuesday 2012-08-07 01:39, Joe Perches wrote:
> >On Mon, 2012-08-06 at 13:50 -0700, David Miller wrote:
> >> > + /*
> >> > + * We don't notify NETDEV_RELEASE event, as this will
> >> > + * stop netconsole on the bridge.
> >> > + */
> >>
> >> Please format comments in the networking:
> >>
> >> /* Like
> >> * this.
> >> */
> >
> >Maybe add a networking specific block comment style
> >to checkpatch. This doesn't trigger on files outside
> >of drivers/net and net.
>
> Is there any particular reason why net/ wants to be special?
A determined maintainer with a strong desire
for consistency using an idiomatic style.
A thread about it:
https://lkml.org/lkml/2012/4/16/443
next prev parent reply other threads:[~2012-08-10 11:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 14:23 [PATCH v2 0/8] some netpoll and netconsole fixes Cong Wang
2012-08-06 14:23 ` [PATCH 1/8] netpoll: use GFP_ATOMIC in slave_enable_netpoll() and __netpoll_setup() Cong Wang
2012-08-06 15:20 ` Eric Dumazet
2012-08-07 2:28 ` Cong Wang
2012-08-06 14:23 ` [PATCH 2/8] netpoll: make __netpoll_cleanup non-block Cong Wang
2012-08-06 14:23 ` [PATCH 3/8] netconsole: do not release spin_lock when calling __netpoll_cleanup Cong Wang
2012-08-06 14:23 ` [PATCH 4/8] netpoll: take rcu_read_lock_bh() in netpoll_rx() Cong Wang
2012-08-06 14:23 ` [PATCH 5/8] netpoll: use netpoll_rx_on() " Cong Wang
2012-08-06 14:23 ` [PATCH 6/8] netpoll: take rcu_read_lock_bh() in netpoll_send_skb_on_dev() Cong Wang
2012-08-06 14:23 ` [PATCH 7/8] bridge: add some comments for NETDEV_RELEASE Cong Wang
2012-08-06 20:50 ` David Miller
2012-08-06 23:39 ` Joe Perches
2012-08-10 10:59 ` Jan Engelhardt
2012-08-10 11:13 ` Joe Perches [this message]
2012-08-07 2:27 ` Cong Wang
2012-08-07 5:59 ` [Resend PATCH " Cong Wang
2012-08-07 7:10 ` David Miller
2012-08-07 15:13 ` Cong Wang
2012-08-06 14:23 ` [PATCH 8/8] bridge: use list_for_each_entry() in netpoll functions Cong Wang
2012-08-11 18:07 ` Stephen Hemminger
2012-08-07 6:58 ` [PATCH v2 0/8] some netpoll and netconsole fixes Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344597198.2338.9.camel@joe2Laptop \
--to=joe@perches.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=jengelh@inai.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).