Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, lp2s1h@gmail.com
Subject: Re: [PATCH] codel: refine one condition to avoid a nul rec_inv_sqrt
Date: Fri, 10 Aug 2012 17:16:11 +0200	[thread overview]
Message-ID: <1344611771.31104.2716.camel@edumazet-glaptop> (raw)
In-Reply-To: <20120730.145412.1689803770003231369.davem@davemloft.net>

On Mon, 2012-07-30 at 14:54 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 30 Jul 2012 08:52:21 +0200
> 
> > From: Eric Dumazet <edumazet@google.com>
> > 
> > One condition before codel_Newton_step() was not good if
> > we never left the dropping state for a flow. As a result
> > rec_inv_sqrt was 0, instead of the ~0 initial value.
> > 
> > codel control law was then set to a very aggressive mode, dropping
> > many packets before reaching 'target' and recovering from this problem.
> > 
> > To keep codel_vars_init() as efficient as possible, refine
> > the condition to make sure rec_inv_sqrt initial value is correct
> > 
> > Many thanks to Anton Mich for discovering the issue and suggesting
> > a fix.
> > 
> > Reported-by: Anton Mich <lp2s1h@gmail.com>
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> 
> Applied and queued up for -stable.

Hi David, I think this patch got lost somehow ?

Thanks

  reply	other threads:[~2012-08-10 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30  6:52 [PATCH] codel: refine one condition to avoid a nul rec_inv_sqrt Eric Dumazet
2012-07-30 21:54 ` David Miller
2012-08-10 15:16   ` Eric Dumazet [this message]
2012-08-10 23:54     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344611771.31104.2716.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=lp2s1h@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox