* [PATCH] bnx2x: Fix compiler warnings
@ 2012-08-12 3:10 Joren Van Onder
2012-08-12 4:50 ` Yuval Mintz
0 siblings, 1 reply; 3+ messages in thread
From: Joren Van Onder @ 2012-08-12 3:10 UTC (permalink / raw)
To: eilong; +Cc: netdev, linux-kernel, Joren Van Onder
Fix the following compiler warnings:
- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:2908:3: warning: comparison
of distinct pointer types lacks a cast [enabled by default]
- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:1709:7: warning: comparison
of distinct pointer types lacks a cast [enabled by default]
Signed-off-by: Joren Van Onder <joren.vanonder@gmail.com>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index 77bcd4c..463b9ec 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
@@ -1278,7 +1278,7 @@ struct bnx2x {
#define BNX2X_FW_RX_ALIGN_START (1UL << BNX2X_RX_ALIGN_SHIFT)
#define BNX2X_FW_RX_ALIGN_END \
- max(1UL << BNX2X_RX_ALIGN_SHIFT, \
+ max_t(u64, 1UL << BNX2X_RX_ALIGN_SHIFT, \
SKB_DATA_ALIGN(sizeof(struct skb_shared_info)))
#define BNX2X_PXP_DRAM_ALIGN (BNX2X_RX_ALIGN_SHIFT - 5)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bnx2x: Fix compiler warnings
2012-08-12 3:10 [PATCH] bnx2x: Fix compiler warnings Joren Van Onder
@ 2012-08-12 4:50 ` Yuval Mintz
2012-08-12 20:42 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Yuval Mintz @ 2012-08-12 4:50 UTC (permalink / raw)
To: Joren Van Onder; +Cc: eilong, netdev, linux-kernel
> Fix the following compiler warnings:
>
> - drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:2908:3: warning: comparison
> of distinct pointer types lacks a cast [enabled by default]
> - drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:1709:7: warning: comparison
> of distinct pointer types lacks a cast [enabled by default]
>
> Signed-off-by: Joren Van Onder <joren.vanonder@gmail.com>
Thanks Joren.
Acked-By: Yuval Mintz <yuvalmin@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bnx2x: Fix compiler warnings
2012-08-12 4:50 ` Yuval Mintz
@ 2012-08-12 20:42 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2012-08-12 20:42 UTC (permalink / raw)
To: yuvalmin; +Cc: joren.vanonder, eilong, netdev, linux-kernel
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Sun, 12 Aug 2012 07:50:48 +0300
>> Fix the following compiler warnings:
>>
>> - drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:2908:3: warning: comparison
>> of distinct pointer types lacks a cast [enabled by default]
>> - drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:1709:7: warning: comparison
>> of distinct pointer types lacks a cast [enabled by default]
>>
>> Signed-off-by: Joren Van Onder <joren.vanonder@gmail.com>
> Thanks Joren.
> Acked-By: Yuval Mintz <yuvalmin@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-08-12 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-12 3:10 [PATCH] bnx2x: Fix compiler warnings Joren Van Onder
2012-08-12 4:50 ` Yuval Mintz
2012-08-12 20:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).