From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Efremov Subject: [PATCH v2] macvtap: rcu_dereference outside read-lock section Date: Sun, 12 Aug 2012 10:26:31 +0400 Message-ID: <1344752791-21140-1-git-send-email-yefremov.denis@gmail.com> References: <20120811.181642.1587792778007257202.davem@davemloft.net> Cc: Denis Efremov , "Michael S. Tsirkin" , Jason Wang , "Eric W. Biederman" , Ian Campbell , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@ispras.ru To: "David S. Miller" Return-path: In-Reply-To: <20120811.181642.1587792778007257202.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org rcu_dereference occurs in update section. Replacement by rcu_dereference_protected in order to prevent lockdep complaint. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Denis Efremov --- drivers/net/macvtap.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 0737bd4..0f0f9ce 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -94,7 +94,8 @@ static int get_slot(struct macvlan_dev *vlan, struct macvtap_queue *q) int i; for (i = 0; i < MAX_MACVTAP_QUEUES; i++) { - if (rcu_dereference(vlan->taps[i]) == q) + if (rcu_dereference_protected(vlan->taps[i], + lockdep_is_held(&macvtap_lock)) == q) return i; } -- 1.7.7