From: Cong Wang <amwang@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 1/2] net: move and rename netif_notify_peers()
Date: Mon, 13 Aug 2012 10:46:42 +0800 [thread overview]
Message-ID: <1344826002.22116.3.camel@cr0> (raw)
In-Reply-To: <1344625276.2701.10.camel@bwh-desktop.uk.solarflarecom.com>
On Fri, 2012-08-10 at 20:01 +0100, Ben Hutchings wrote:
> On Fri, 2012-08-10 at 16:14 +0800, Cong Wang wrote:
> > I believe net/core/dev.c is a better place for netif_notify_peers(),
> > because other net event notify functions also stay in this file.
> >
> > And rename it to netdev_notify_peers().
> [...]
>
> Is there a convention for using the 'netdev' vs 'netif' prefixes?
> If not, I don't see the point in renaming just this one function.
>
The reason why I rename it is there are more functions named netdev_*
than netif_* in net/core/dev.c. Also given that netdev_bonding_change()
has netdev_ prefix too.
I don't have strong opinions on this.
Thanks.
next prev parent reply other threads:[~2012-08-13 2:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 8:14 [PATCH 1/2] net: move and rename netif_notify_peers() Cong Wang
2012-08-10 8:14 ` [PATCH 2/2] net: remove netdev_bonding_change() Cong Wang
2012-08-14 21:29 ` David Miller
2012-08-10 19:01 ` [PATCH 1/2] net: move and rename netif_notify_peers() Ben Hutchings
2012-08-13 2:46 ` Cong Wang [this message]
2012-08-14 21:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344826002.22116.3.camel@cr0 \
--to=amwang@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).