From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, faisal.latif@intel.com,
roland@kernel.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, fubar@us.ibm.com, andy@greyhouse.net,
divy@chelsio.com, jitendra.kalsaria@qlogic.com,
sony.chacko@qlogic.com, linux-driver@qlogic.com, kaber@trash.net,
ursula.braun@de.ibm.com, blaschka@linux.vnet.ibm.com,
linux390@de.ibm.com, shemminger@vyatta.com,
bhutchings@solarflare.com, therbert@google.com,
xiyou.wangcong@gmail.com, joe@perches.com,
gregory.v.rose@intel.com, john.r.fastabend@intel.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org, bridge@lists.linux-foundation.org,
fbl@redhat.com
Subject: [patch net-next v2 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock
Date: Tue, 14 Aug 2012 17:05:42 +0200 [thread overview]
Message-ID: <1344956748-2099-10-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1344956748-2099-1-git-send-email-jiri@resnulli.us>
rcu_read_lock was missing here
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 212c121..9eadf17 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -4425,12 +4425,14 @@ qlcnic_restore_indev_addr(struct net_device *netdev, unsigned long event)
qlcnic_config_indev_addr(adapter, netdev, event);
+ rcu_read_lock();
for_each_set_bit(vid, adapter->vlans, VLAN_N_VID) {
dev = __vlan_find_dev_deep(netdev, vid);
if (!dev)
continue;
qlcnic_config_indev_addr(adapter, dev, event);
}
+ rcu_read_unlock();
}
static int qlcnic_netdev_event(struct notifier_block *this,
--
1.7.10.4
next prev parent reply other threads:[~2012-08-14 15:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 15:05 [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 01/15] net: introduce upper device lists Jiri Pirko
2012-08-14 22:33 ` Ben Hutchings
2012-08-14 23:00 ` Stephen Hemminger
2012-08-15 7:46 ` Jiri Pirko
2012-08-15 22:15 ` David Miller
[not found] ` <20120815.151549.1835466517645273818.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-08-16 5:48 ` Jiri Pirko
2012-08-15 22:12 ` David Miller
2012-08-14 15:05 ` [patch net-next v2 02/15] macvlan: add link to upper device Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 03/15] vlan: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 04/15] rtnetlink: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 05/15] team: remove usage of netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 06/15] bridge: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 07/15] netpoll: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 08/15] cxgb3: " Jiri Pirko
2012-08-14 15:05 ` Jiri Pirko [this message]
2012-08-14 15:05 ` [patch net-next v2 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock Jiri Pirko
[not found] ` <1344956748-2099-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-14 15:05 ` [patch net-next v2 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep() Jiri Pirko
2012-08-14 20:19 ` [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Andy Gospodarek
2012-08-14 20:32 ` Ben Hutchings
2012-08-15 7:30 ` Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 12/15] nes: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 13/15] bonding: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 15/15] net: kill dev->master Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344956748-2099-10-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=andy@greyhouse.net \
--cc=bhutchings@solarflare.com \
--cc=blaschka@linux.vnet.ibm.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=edumazet@google.com \
--cc=faisal.latif@intel.com \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=gregory.v.rose@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
--cc=shemminger@vyatta.com \
--cc=sony.chacko@qlogic.com \
--cc=therbert@google.com \
--cc=ursula.braun@de.ibm.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).