netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@google.com, faisal.latif@intel.com,
	roland@kernel.org, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, fubar@us.ibm.com, andy@greyhouse.net,
	divy@chelsio.com, jitendra.kalsaria@qlogic.com,
	sony.chacko@qlogic.com, linux-driver@qlogic.com, kaber@trash.net,
	ursula.braun@de.ibm.com, blaschka@linux.vnet.ibm.com,
	linux390@de.ibm.com, shemminger@vyatta.com,
	bhutchings@solarflare.com, therbert@google.com,
	xiyou.wangcong@gmail.com, joe@perches.com,
	gregory.v.rose@intel.com, john.r.fastabend@intel.com,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org, bridge@lists.linux-foundation.org,
	fbl@redhat.com
Subject: [patch net-next v2 07/15] netpoll: remove usage of dev->master
Date: Tue, 14 Aug 2012 17:05:40 +0200	[thread overview]
Message-ID: <1344956748-2099-8-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1344956748-2099-1-git-send-email-jiri@resnulli.us>

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 net/core/netpoll.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index b4c90e4..1f457a6 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -207,12 +207,16 @@ static void netpoll_poll_dev(struct net_device *dev)
 
 	if (dev->flags & IFF_SLAVE) {
 		if (dev->npinfo) {
-			struct net_device *bond_dev = dev->master;
+			struct net_device *bond_dev;
 			struct sk_buff *skb;
+
+			rcu_read_lock();
+			bond_dev = netdev_master_upper_dev_get_rcu(dev);
 			while ((skb = skb_dequeue(&dev->npinfo->arp_tx))) {
 				skb->dev = bond_dev;
 				skb_queue_tail(&bond_dev->npinfo->arp_tx, skb);
 			}
+			rcu_read_unlock();
 		}
 	}
 
@@ -795,7 +799,7 @@ int netpoll_setup(struct netpoll *np)
 		return -ENODEV;
 	}
 
-	if (ndev->master) {
+	if (netdev_master_upper_dev_get(ndev)) {
 		np_err(np, "%s is a slave device, aborting\n", np->dev_name);
 		err = -EBUSY;
 		goto put;
-- 
1.7.10.4

  parent reply	other threads:[~2012-08-14 15:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 15:05 [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 01/15] net: introduce upper device lists Jiri Pirko
2012-08-14 22:33   ` Ben Hutchings
2012-08-14 23:00     ` Stephen Hemminger
2012-08-15  7:46     ` Jiri Pirko
2012-08-15 22:15       ` David Miller
     [not found]         ` <20120815.151549.1835466517645273818.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2012-08-16  5:48           ` Jiri Pirko
2012-08-15 22:12     ` David Miller
2012-08-14 15:05 ` [patch net-next v2 02/15] macvlan: add link to upper device Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 03/15] vlan: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 04/15] rtnetlink: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 05/15] team: remove usage of netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 06/15] bridge: " Jiri Pirko
2012-08-14 15:05 ` Jiri Pirko [this message]
2012-08-14 15:05 ` [patch net-next v2 08/15] cxgb3: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 10/15] qeth: ensure that __vlan_find_dev_deep() is called with rcu_read_lock Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 12/15] nes: remove usage of dev->master Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 13/15] bonding: " Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 14/15] net: remove no longer used netdev_set_bond_master() and netdev_set_master() Jiri Pirko
2012-08-14 15:05 ` [patch net-next v2 15/15] net: kill dev->master Jiri Pirko
     [not found] ` <1344956748-2099-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2012-08-14 15:05   ` [patch net-next v2 11/15] vlan: remove usage of dev->master in __vlan_find_dev_deep() Jiri Pirko
2012-08-14 20:19   ` [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master Andy Gospodarek
2012-08-14 20:32     ` Ben Hutchings
2012-08-15  7:30       ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1344956748-2099-8-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=andy@greyhouse.net \
    --cc=bhutchings@solarflare.com \
    --cc=blaschka@linux.vnet.ibm.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=divy@chelsio.com \
    --cc=edumazet@google.com \
    --cc=faisal.latif@intel.com \
    --cc=fbl@redhat.com \
    --cc=fubar@us.ibm.com \
    --cc=gregory.v.rose@intel.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=jitendra.kalsaria@qlogic.com \
    --cc=joe@perches.com \
    --cc=john.r.fastabend@intel.com \
    --cc=kaber@trash.net \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=shemminger@vyatta.com \
    --cc=sony.chacko@qlogic.com \
    --cc=therbert@google.com \
    --cc=ursula.braun@de.ibm.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).