From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH 15/21] net sched: Pass the skb into change so it can access NETLINK_CB Date: Wed, 15 Aug 2012 04:11:54 -0400 Message-ID: <1345018314.20443.4.camel@mojatatu> References: <87ehnav9n5.fsf@xmission.com> <1344889115-21610-1-git-send-email-ebiederm@xmission.com> <1344889115-21610-15-git-send-email-ebiederm@xmission.com> Reply-To: jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Miller To: "Eric W. Biederman" Return-path: In-Reply-To: <1344889115-21610-15-git-send-email-ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, 2012-08-13 at 13:18 -0700, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > cls_flow.c plays with uids and gids. Unless I misread that > code it is possible for classifiers to depend on the specific uid and > gid values. Therefore I need to know the user namespace of the > netlink socket that is installing the packet classifiers. Pass > in the rtnetlink skb so I can access the NETLINK_CB of the passed > packet. In particular I want access to sk_user_ns(NETLINK_CB(in_skb).ssk). > > Pass in not the user namespace but the incomming rtnetlink skb into > the the classifier change routines as that is generally the more useful > parameter. > > Cc: Jamal Hadi Salim > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman Acked-by: Jamal Hadi Salim cheers, jamal