From: Joe Perches <joe@perches.com>
To: cjren@qca.qualcomm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, qca-linux-team@qualcomm.com,
nic-devel@qualcomm.com, Xiong Huang <xiong@qca.qualcomm.com>,
"Luis R. Rodriguez" <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH] net: add new QCA alx ethernet driver
Date: Thu, 16 Aug 2012 06:16:23 -0700 [thread overview]
Message-ID: <1345122983.26882.9.camel@joe2Laptop> (raw)
In-Reply-To: <1345053189-10326-1-git-send-email-cjren@qca.qualcomm.com>
On Thu, 2012-08-16 at 01:53 +0800, cjren@qca.qualcomm.com wrote:
> From: Cloud Ren <cjren@qca.qualcomm.com>
>
> This driver support two new ethernet chipsets:
> 1969:1091 - AR8161 Gigabit Ethernet
> 1969:1090 - AR8162 Fast Ethernet
[]
> diff --git a/drivers/net/ethernet/atheros/alx/alx_main.c b/drivers/net/ethernet/atheros/alx/alx_main.c
[]
> +/*
> + * alx_hw_printk
> + */
> +void alx_hw_printk(const char *level, const struct alx_hw *hw,
> + const char *fmt, ...)
> +{
> + struct va_format vaf;
> + va_list args;
> +
> + va_start(args, fmt);
> + vaf.fmt = fmt;
> + vaf.va = &args;
> +
> + if (hw && hw->adpt && hw->adpt->netdev)
> + __netdev_printk(level, hw->adpt->netdev, &vaf);
Hi Cloud. Please convert this to
netdev_printk(level, hw->adpt->netdev, "%pV", &vaf);
I will submit a patch soon to make the __netdev_printk variant static.
next prev parent reply other threads:[~2012-08-16 13:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 17:53 [PATCH] net: add new QCA alx ethernet driver cjren
2012-08-16 13:16 ` Joe Perches [this message]
2012-08-17 1:49 ` Ren, Cloud
-- strict thread matches above, loose matches on Subject: below --
2012-08-09 10:14 cjren
2012-08-09 2:27 ` Ren, Cloud
2012-08-09 4:09 ` Joe Perches
2012-08-09 4:44 ` Ren, Cloud
2012-08-09 6:18 ` David Miller
2012-08-09 6:49 ` Ren, Cloud
2012-08-09 7:58 ` Joe Perches
2012-08-09 8:25 ` Ren, Cloud
2012-08-09 14:54 ` Steven Rostedt
2012-08-09 15:22 ` Joe Perches
2012-08-09 15:28 ` Steven Rostedt
2012-08-09 18:56 ` Ben Hutchings
2012-08-10 0:26 ` Huang, Xiong
2012-08-09 19:13 ` Luis R. Rodriguez
2012-08-09 19:31 ` Luis R. Rodriguez
2012-08-09 6:14 ` David Miller
2012-08-09 6:11 ` David Miller
2012-08-11 20:50 ` Stephen Hemminger
2012-08-13 1:19 ` Huang, Xiong
2012-08-15 3:29 ` Ren, Cloud
2012-08-15 5:32 ` David Miller
2012-08-15 5:39 ` Ren, Cloud
2012-08-15 15:02 ` Stephen Hemminger
2012-08-16 2:19 ` Ren, Cloud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345122983.26882.9.camel@joe2Laptop \
--to=joe@perches.com \
--cc=cjren@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).