* [Patch] netconsole: remove a redundant netconsole_target_put()
@ 2012-08-18 17:02 Cong Wang
2012-08-20 10:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2012-08-18 17:02 UTC (permalink / raw)
To: netdev; +Cc: David Miller, stable, Cong Wang
This netconsole_target_put() is obviously redundant, and it
causes a kernel segfault when removing a bridge device which has
netconsole running on it.
This is caused by:
commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093
Author: Amerigo Wang <amwang@redhat.com>
Date: Thu May 19 21:39:10 2011 +0000
netpoll: disable netpoll when enslave a device
Cc: David Miller <davem@davemloft.net>
(for all 3.x stable releases)
Cc: stable@vger.kernel.org
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index f0ad56c..b332112 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -643,7 +643,6 @@ static int netconsole_netdev_event(struct notifier_block *this,
__netpoll_cleanup(&nt->np);
dev_put(nt->np.dev);
nt->np.dev = NULL;
- netconsole_target_put(nt);
}
nt->enabled = 0;
stopped = true;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] netconsole: remove a redundant netconsole_target_put()
2012-08-18 17:02 [Patch] netconsole: remove a redundant netconsole_target_put() Cong Wang
@ 2012-08-20 10:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-08-20 10:00 UTC (permalink / raw)
To: amwang; +Cc: netdev, stable
From: Cong Wang <amwang@redhat.com>
Date: Sun, 19 Aug 2012 01:02:20 +0800
> This netconsole_target_put() is obviously redundant, and it
> causes a kernel segfault when removing a bridge device which has
> netconsole running on it.
>
> This is caused by:
>
> commit 8d8fc29d02a33e4bd5f4fa47823c1fd386346093
> Author: Amerigo Wang <amwang@redhat.com>
> Date: Thu May 19 21:39:10 2011 +0000
>
> netpoll: disable netpoll when enslave a device
>
> Cc: David Miller <davem@davemloft.net>
> (for all 3.x stable releases)
> Cc: stable@vger.kernel.org
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-20 10:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-18 17:02 [Patch] netconsole: remove a redundant netconsole_target_put() Cong Wang
2012-08-20 10:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).